Merge pull request #472 from y-van-z/mbs-9219-fix-profile-editing

MBS-9219: Fix editing known languages field in user profile form
metabrainz · Feb 20, 2017 · d8ebdbb · d8ebdbb
2 parents dfd93d9 + 547b27e
commit d8ebdbb
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/root/account/edit.tt b/root/account/edit.tt
@@ -65,7 +65,7 @@
             </span>
             [% extra_field = form.field('languages').field(form.field('languages').add_extra(1) - 1) %]
             <span id="add-language-template" style="display: none">
-              [% r.select(extra_field.field('language_id'), id => 'fluency-template', class => 'language_id',) %]
+              [% r.select(extra_field.field('language_id'), class => 'language_id') %]
               [% r.select(extra_field.field('fluency'), class => 'fluency') %]
               <span class="buttons inline">
                 <button type="button" class="remove negative">[% l('Remove') %]</button>
@@ -77,6 +77,9 @@
 
       <script>//<![CDATA[
       $(function () {
+          $(document.body).append( $('#add-language-template') );
+          $('#add-language-template').children().removeAttr('id').removeAttr('name');
+
           var languageCount = $('li.language').size();
 
           $('#edit-profile-form').on('click', 'button.remove', function (event) {
@@ -87,15 +90,15 @@
           $('button.another').click(function (event) {
               event.preventDefault();
 
-              languageCount++;
-
               var newLanguage = $('<li>').append($('#add-language-template').clone().contents());
               newLanguage.find('select.language_id').attr('name',
                                                           'profile.languages.' + languageCount + '.language_id');
               newLanguage.find('select.fluency').attr('name',
                                                       'profile.languages.' + languageCount + '.fluency');
 
               $(this).parents('li').before(newLanguage);
+
+              languageCount++;
           });
       });
       //]]></script>