MBS-12387: Add titles to URL editor edit buttons

It's not always clear what the pencil means, especially when there's one for the URL itself and one for each relationship the URL is used in. This adds the titles directly to the popover/dialog files, since they are only used for this.
metabrainz · May 30, 2022 · f6e8892 · f6e8892
1 parent 75177fa
commit f6e8892
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/root/static/scripts/edit/components/ExternalLinkAttributeDialog.js b/root/static/scripts/edit/components/ExternalLinkAttributeDialog.js
@@ -231,6 +231,7 @@ const ExternalLinkAttributeDialog = (props: PropsT): React.MixedElement => {
       buttonContent={null}
       buttonProps={{
         className: 'icon edit-item',
+        title: l('Edit Relationship Details'),
       }}
       buttonRef={buttonRef}
       id="external-link-attribute-dialog"

diff --git a/root/static/scripts/edit/components/URLInputPopover.js b/root/static/scripts/edit/components/URLInputPopover.js
@@ -144,7 +144,7 @@ const URLInputPopover = (props: PropsT): React.MixedElement => {
     <ButtonPopover
       buildChildren={buildPopoverChildren}
       buttonContent={null}
-      buttonProps={{className: 'icon edit-item'}}
+      buttonProps={{className: 'icon edit-item', title: l('Edit Link')}}
       buttonRef={popoverButtonRef}
       id="url-input-popover"
       isOpen={isOpen}