MBS-10133: Clarify "empty query" bad request error #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
requested changes
May 24, 2019
mwiencek
approved these changes
May 28, 2019
yvanzo
reviewed
Jun 3, 2019
yvanzo
force-pushed
the
MBS-10133
branch
2 times, most recently
from
0a058e4
to
61476dc
Compare
This still allows a query like \" through, in case the user does want to query for entities with quote marks in their name.
JSON WS now outputs the same doc link as the XML WS error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-10133
Collections aren't searched through the search server at all, if https://musicbrainz.org/doc/Development/XML_Web_Service/Version_2/Search is correct. As such, this should just say that the blank query was blank.
Also generalize what is seen as a blank query: given we can't have empty string or whitespaces as names,
"",''or" "should also be rejected as blank queries. Escaped quote marks, such asquery=\", should be allowed in order to allow searching for fields containing quote marks.