Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-6087: Show relationship edits for recordings on release edit list #1072

Merged
merged 1 commit into from Jul 24, 2019

Conversation

reosarevok
Copy link
Member

Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows the edit in /open_edits but it still doesn’t set class mp on any entity of the relationship in the tracklist. Tests would be welcome.

Copy link
Member

@mwiencek mwiencek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lack of an mp class seems unrelated to MBS-6087? A separate ticket might be better for that.

@reosarevok
Copy link
Member Author

Unrelated and tricky (since we'd want to only select the specific relationship somehow - is this a thing we can do in any reasonable way at the moment? do we have edits_pending for specific relationships? If we do, then we need a ticket and I can look into it at some point too)

@mwiencek
Copy link
Member

mwiencek commented Jul 4, 2019

There should be a way by overriding alter_edit_pending, but it's not something we do for relationships in general, so I'm not sure it makes sense to create an exception here unless we do it for all. For example, if you're to currently add or edit or remove a relationship, we don't even increment edits_pending for the entities on the relationship, let alone indirect entities (like releases using a particular recording). Perhaps that's something we want, but it's a separate issue at least.

Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edits history works fine.

Created ticket MBS-10284 accordingly.

@reosarevok reosarevok merged commit 0774d48 into metabrainz:master Jul 24, 2019
@reosarevok reosarevok deleted the MBS-10158 branch July 24, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants