MBS-10562: Add phrases for future (sidebar) dates #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
changed the title
reosarevok
force-pushed
the
MBS-10562
branch
from
4d28c16
to
3ff03eb
Compare
reosarevok
changed the title
yvanzo
requested changes
Jun 10, 2020
This only adds the option for cases that seem likely to happen and where we have custom phrases already. The opening and closing of a place can be announced ahead of time, and so can the dissolution of a group (but it would be strange to announce the foundation of a group before it happens, very dodgy to announce the death of a person and pretty much impossible to specify the birth of one).
mwiencek
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MBS-10562
This only adds the option for cases that seem likely to happen and where we have custom phrases already. The opening and closing of a place can be announced ahead of time, and so can the dissolution of a group (but it would be strange to announce the foundation of a group before it happens, very dodgy to announce the death of a person and pretty much impossible to specify the birth of one).