Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-10392 Convert Add Series edit to React #1357

Merged
merged 2 commits into from Jan 28, 2020

Conversation

anirudhjain75
Copy link
Contributor

No description provided.

Copy link
Member

@reosarevok reosarevok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a good conversion, but we should improve it a bit while at it :)

root/edit/details/AddSeries.js Outdated Show resolved Hide resolved
root/edit/details/AddSeries.js Outdated Show resolved Hide resolved
root/edit/details/AddSeries.js Outdated Show resolved Hide resolved
root/edit/details/AddSeries.js Show resolved Hide resolved
Copy link
Member

@reosarevok reosarevok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally shows this seems fine now.

@mwiencek
Copy link
Member

This would crash trying to display edits where the series was later deleted. I fixed that and some minor issues with the Flow types. See https://github.com/metabrainz/musicbrainz-server/compare/890c5a11eb1beec038004845f5b35164693d1e3e..89d79a101455933e7845df7d3cd32c5194a96f9a

@mwiencek mwiencek merged commit e5236f0 into metabrainz:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants