Install pkg-config to probe ICU headers/libraries #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anticipate postgresql-musicbrainz-collate's switch to pkg-config at metabrainz/postgresql-musicbrainz-collate#5 Unicode::ICU::Collator 0.004 already uses pkg-config if available, see https://rt.cpan.org/Public/Bug/Display.html?id=86373
mwiencek
reviewed
Jan 20, 2020
mwiencek
approved these changes
Jan 20, 2020
mwiencek
added a commit
that referenced
this pull request
Jan 21, 2020
* master: Update translations from transifex. Update POT files using the production database Install pkg-config to probe ICU headers/libraries (#1360) Fix MBS-10572: Have one Jed bundle per language (#1359) MBS-10571: Fix "localized" ModBot email display (#1358) Eslint fixes: no-prototype-builtins Document musicbrainz_selenium creation MBS-10567: Limit series types as per DB constraint (#1351) MBS-10560: Show full country names in release edits (#1353) MBS-10536: Remove span.name-variation around "see all" releases link (#1354) Remove unneeded extra newlines MBS-10365: Convert ReleaseList to react-table Eslint sort-keys fixes MBS-10552: Add Deezer links to the sidebar
mwiencek
added a commit
that referenced
this pull request
Jan 21, 2020
* beta: Update translations from transifex. Update POT files using the production database Install pkg-config to probe ICU headers/libraries (#1360) Fix MBS-10572: Have one Jed bundle per language (#1359) MBS-10571: Fix "localized" ModBot email display (#1358) Eslint fixes: no-prototype-builtins Document musicbrainz_selenium creation MBS-10567: Limit series types as per DB constraint (#1351) MBS-10560: Show full country names in release edits (#1353) MBS-10536: Remove span.name-variation around "see all" releases link (#1354) Remove unneeded extra newlines MBS-10365: Convert ReleaseList to react-table Update POT files Update translations from Transifex MBS-10565: Fix item_entity_type field name (#1350) Bump Flow to 0.116.0 MBS-10553: Translate report reason only if needed (#1346) Handle when maps service access token is not set Document MAPBOX_ACCESS_TOKEN in sample config Rename merge_entities to transfer_to_merge_target MBS-10522: Save subscriptions to merge destination MBS-10501: Show collaborator avatars on collection (#1342) MBS-9491: List genre on tag search results (#1064) More documentation tweaks. - Changed some of the wording around the PostgreSQL user. - Avoid using raw URLs. - Link to mb.org instead of ftp.mb.org for obtaining database dumps. - Unfortunately, that page does not include any info about the sample data set, so that section needs to describe how to adjust the download URL. - Dropped information about a CPAN bug that was resolved in 2013. Eslint sort-keys fixes MBS-10552: Add Deezer links to the sidebar MBS-10492: Display leading 0 in minute and second (#1341) Reworked the translation section. The prerequisites now list detailed Transifex information (and make it clear it is NOT required to use the translations that are under version control). Added a sentence explaining the format for languages. Adjusted database user documentation. Instead of describing how to change a user's password, simply mention that the database creation script will also create the database user if needed. Bump Flow to 0.115.0 Updated the installation guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anticipate postgresql-musicbrainz-collate's switch to pkg-config at metabrainz/postgresql-musicbrainz-collate#5.
Unicode::ICU::Collator 0.004 already uses pkg-config if available, see https://rt.cpan.org/Public/Bug/Display.html?id=86373