MBS-10579: Unbreak es-es/el-gr translations #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code and associated comment here don't make sense to me. The language used in the Jed files should match what's in DBDefs, since that's what gets set in the lang cookie and is what's used to fetch the file. I'd also be in favor of changing these to es/el (without country codes) in MB_LANGUAGES in production and removing the symlinks - they were to work around a bug in Locale::Util that's been fixed for years. But in that case we'd still remove this code as unused.
reosarevok
approved these changes
Jan 24, 2020
yvanzo
approved these changes
Jan 30, 2020
They're actually es and el in Transifex. I mentioned why we have the symlinks in the commit message/PR description:
Basically, |
|
Thanks, I was just surprised it affected specifically these two languages and not every other (de, fr, …). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.metabrainz.org/browse/MBS-10579
The code and associated comment here don't make sense to me. The language used in the Jed files should match what's in DBDefs, since that's what gets set in the lang cookie and is what's used to fetch the file.
I'd also be in favor of changing these to es/el (without country codes) in
MB_LANGUAGESin production and removing the symlinks - they were to work around a bug inLocale::Utilthat's been fixed for years. But in that case we'd still remove this code as unused.