Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBS-10594: Fail add annotation edit if entity is gone #1388

Merged
merged 1 commit into from Feb 19, 2020
Merged

MBS-10594: Fail add annotation edit if entity is gone #1388

merged 1 commit into from Feb 19, 2020

Conversation

reosarevok
Copy link
Member

@reosarevok reosarevok added the Bug Bugs that should be checked/fixed soonish label Feb 17, 2020
@reosarevok reosarevok added this to the Tiburón Abuelo milestone Feb 17, 2020
yvanzo
yvanzo approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is way too complicated to test by hand since an entity removal has an irreducible voting period of a week, thus an automated test would have been welcome.

@reosarevok
Copy link
Member Author

It is way too complicated to test by hand since an entity removal has an irreducible voting period of a week

It doesn't in a development server :) I tested it by hand myself.

@reosarevok reosarevok merged commit 639ca2d into metabrainz:master Feb 19, 2020
@reosarevok reosarevok deleted the MBS-10594 branch February 19, 2020 21:53
yvanzo pushed a commit to yvanzo/musicbrainz-server that referenced this pull request Feb 19, 2020
@reosarevok @yvanzo
MBS-10594: Fail add annotation edit if entity is gone (metabrainz#1388)
934a2ae
yvanzo added a commit that referenced this pull request Feb 26, 2020
@yvanzo
Merge branch 'master' into beta
403849b 
* master:
  Update POT files using the production database
  Update translations from Transifex
  Fix warning about artwork image suffix on homepage (#1394)
  MBS-10659: Always show entity credits in rel edits (#1398)
  MBS-10166: Add genre entity to the WS (#1066)
  Fix warning: uninitialized value in numeric gt (>) (#1381)
  MBS-10617 : Convert Add Work edit to React
  Fix warning: uninitialized value in numeric eq (==)
  MBS-10058: Convert historic/merge_releases to React
  Remove entity lists from components.js
  MBS-10155: Make ReleaseGroupList always group by type
  MBS-10058: Convert merge_release_groups to React
  MBS-10058: Convert merge_works to React
  MBS-10058: Convert merge_series to React
  MBS-10058: Convert merge_recordings to React
  MBS-10058: Convert merge_places to React
  MBS-10058: Convert merge_labels to React
  MBS-10058: Convert merge_instruments to React
  MBS-10058: Convert merge_events to React
  Remove now unused merge_common.tt
  MBS-10058: Convert merge_artists to React
  MBS-10058: Convert merge_areas to React
  Fix warning: uninitialized value in numeric ne (!=)
  MBS-10594: Fail add annotation edit if entity is gone (#1388)
  Fix blog post link in generated git tag message (#1393)
  Document newly required version 10.15 of Node.js (#1392)
  MBS-9654: Show expanded ACs on recording merges (#1260)
  MBS-10643: Add autoselect for artists for CPDL (#1385)
  Eslint auto-fixes for comma-spacing
  Eslint auto-fixes for comma-dangle
  Eslint: fix non-auto-fixable comma-dangle
  Disable no-unused-vars where they're needed
  MBS-10649: Show empty diff side if label deselected
  MBS-10593: Deal with empty country id/name
  Fix handling of tape object serialization
  Merge CircleCI jobs
  Remove --appendonly from test redis config
  Massively speed up TruncateTables.sql in test env
  Clone mb-solr with depth 1
  Recurse submodules at $MB_SOLR_TAG
  Don't compile client JS in CircleCI
  Run Selenium tests on Jenkins
  Allow setting the webpack mode directly
  Install PG extensions in Dockerfile.tests
  Install perl modules in Dockerfile.tests
  Support running Selenium tests in Firefox
  Bump chromedriver to 80.0.3987.16
  Unbreak ujson in sir virtualenv
  Update test image
  Update to MB SOLR v.3.1.2
  MBS-9491: Add genre MBIDs to the WS
  Ignore local::lib files for docker/js tools too (#1382)
  Replace git-core virtual package with git (#1380)
  Fix warning: uninitialized value in subroutine entry
  Fix warning: uninitialized value in addition (+)
  Fix warning: uninitialized value in subroutine entry
yvanzo added a commit that referenced this pull request Mar 2, 2020
@yvanzo
Merge branch 'beta' into production
d4b3cca 
* beta:
  Update POT files using the current code
  Update translations from Transifex
  MBS-10515: Fix sort of release recordings in merge (#1399)
  Update POT files using the production database
  Update translations from Transifex
  Fix warning about artwork image suffix on homepage (#1394)
  MBS-10659: Always show entity credits in rel edits (#1398)
  MBS-10166: Add genre entity to the WS (#1066)
  Fix warning: uninitialized value in numeric gt (>) (#1381)
  MBS-10617 : Convert Add Work edit to React
  Fix warning: uninitialized value in numeric eq (==)
  MBS-10058: Convert historic/merge_releases to React
  Remove entity lists from components.js
  MBS-10155: Make ReleaseGroupList always group by type
  MBS-10058: Convert merge_release_groups to React
  MBS-10058: Convert merge_works to React
  MBS-10058: Convert merge_series to React
  MBS-10058: Convert merge_recordings to React
  MBS-10058: Convert merge_places to React
  MBS-10058: Convert merge_labels to React
  MBS-10058: Convert merge_instruments to React
  MBS-10058: Convert merge_events to React
  Remove now unused merge_common.tt
  MBS-10058: Convert merge_artists to React
  MBS-10058: Convert merge_areas to React
  Fix warning: uninitialized value in numeric ne (!=)
  MBS-10594: Fail add annotation edit if entity is gone (#1388)
  Fix blog post link in generated git tag message (#1393)
  Document newly required version 10.15 of Node.js (#1392)
  MBS-9654: Show expanded ACs on recording merges (#1260)
  MBS-10643: Add autoselect for artists for CPDL (#1385)
  Eslint auto-fixes for comma-spacing
  Eslint auto-fixes for comma-dangle
  Eslint: fix non-auto-fixable comma-dangle
  Disable no-unused-vars where they're needed
  MBS-10649: Show empty diff side if label deselected
  MBS-10593: Deal with empty country id/name
  Fix handling of tape object serialization
  Merge CircleCI jobs
  Remove --appendonly from test redis config
  Massively speed up TruncateTables.sql in test env
  Clone mb-solr with depth 1
  Recurse submodules at $MB_SOLR_TAG
  Don't compile client JS in CircleCI
  Run Selenium tests on Jenkins
  Allow setting the webpack mode directly
  Install PG extensions in Dockerfile.tests
  Install perl modules in Dockerfile.tests
  Support running Selenium tests in Firefox
  Bump chromedriver to 80.0.3987.16
  Unbreak ujson in sir virtualenv
  Update test image
  Update to MB SOLR v.3.1.2
  MBS-9491: Add genre MBIDs to the WS
  Ignore local::lib files for docker/js tools too (#1382)
  Replace git-core virtual package with git (#1380)
  Fix warning: uninitialized value in subroutine entry
  Fix warning: uninitialized value in addition (+)
  Fix warning: uninitialized value in subroutine entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwiencek mwiencek mwiencek approved these changes

@yvanzo yvanzo yvanzo approved these changes

Assignees
No one assigned
Labels
Bug Bugs that should be checked/fixed soonish
Projects
None yet
Milestone
Tiburón Abuelo
3 participants
@reosarevok @mwiencek @yvanzo