MBS-10671: Block ratings for unverified users #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People are creating email-less accounts to mass-rate their favourite boy band. While that's mostly harmless, it's still stupid, and I can't see any reason why we should allow unverified users to submit ratings.
yvanzo
approved these changes
Mar 6, 2020
mwiencek
approved these changes
Mar 6, 2020
yvanzo
added a commit
that referenced
this pull request
Mar 12, 2020
* master: Update POT files using the production database Update translations from Transifex MBS-7835: Old Create work edits should display [No lyrics] for zxx (#1421) MBS-10695: Show language names on work lists (#1420) Upgrade leaflet to the latest version (#1412) MBS-10607: Add context to (unknown) strings (#1400) MBS-10693: Restore FieldErrors for target on artist merges (#1419) Simplify Controller::Artist special-entity checks MBS-10628: Make [no label] really special purpose MBS-10692: Change ReactDOM imports to "import * as ReactDOM" Replace type import by Flow global type MBS-10692: Change React imports to "import * as React" MBS-10633: Allow changing username capitalization (#1403) MBS-9651: Ignore superseded votes for editor stats (#1409) Remove unused single-work-language code MBS-10618: Convert Edit work edit to React MBS-9359: Only load language for each work once (#1416) Fix typo in help message Accept -h, --help, help options without erroring Eslint sort-key fixes MBS-10689: Update MapBox API calls Support setting compression level of dump tar Directly compress with xz while archiving MB dump Replace tar compression option with piped command Drop unneeded dependency on GNU tar Replace direct $tar_bin call with shell command Help on LIST_METABRAINZ_HOSTS environment variable MBS-10684: Correct message for place maps MBS-10685: Combine move + zoom when clicking MBS-10683: Combine moving map and focusing Capture exit status of both piped command MBS-10676: Output MD5SUMS/SHA256SUMS for JSON dumps MBS-10671: Block ratings for unverified users (#1404) MBS-10661: Highlight rec-work pending edits in release (#1402) Bump Flow to 0.120.1 Bump Flow to 0.120.0 Fix warning: uninitialized value in lc (#1383) Fix warning: uninitialized value in hash element Refactor check_event_countries in Edit::Release Fix warning: uninitialized value in exists/hash Fix warning: uninitialized value $artist_type in numeric ne (!=) Fix warning: uninitialized value $ae in pattern match (m//) Fix warning: uninitialized value in string eq
yvanzo
added a commit
that referenced
this pull request
Mar 16, 2020
* beta: Update POT files using the production database Update translations from Transifex MBS-4090: Report: non-matching recording/track titles (#1156) Update POT files using the production database Update translations from Transifex MBS-7835: Old Create work edits should display [No lyrics] for zxx (#1421) MBS-10695: Show language names on work lists (#1420) Upgrade leaflet to the latest version (#1412) MBS-10607: Add context to (unknown) strings (#1400) MBS-10693: Restore FieldErrors for target on artist merges (#1419) Simplify Controller::Artist special-entity checks MBS-10628: Make [no label] really special purpose MBS-10692: Change ReactDOM imports to "import * as ReactDOM" Replace type import by Flow global type MBS-10692: Change React imports to "import * as React" MBS-10633: Allow changing username capitalization (#1403) MBS-9651: Ignore superseded votes for editor stats (#1409) Remove unused single-work-language code MBS-10618: Convert Edit work edit to React MBS-9359: Only load language for each work once (#1416) Fix typo in help message Accept -h, --help, help options without erroring Eslint sort-key fixes MBS-10689: Update MapBox API calls Support setting compression level of dump tar Directly compress with xz while archiving MB dump Replace tar compression option with piped command Drop unneeded dependency on GNU tar Replace direct $tar_bin call with shell command Help on LIST_METABRAINZ_HOSTS environment variable MBS-10684: Correct message for place maps MBS-10685: Combine move + zoom when clicking MBS-10683: Combine moving map and focusing Capture exit status of both piped command MBS-10676: Output MD5SUMS/SHA256SUMS for JSON dumps MBS-10671: Block ratings for unverified users (#1404) MBS-10661: Highlight rec-work pending edits in release (#1402) Bump Flow to 0.120.1 Bump Flow to 0.120.0 Fix warning: uninitialized value in lc (#1383) Fix warning: uninitialized value in hash element Refactor check_event_countries in Edit::Release Fix warning: uninitialized value in exists/hash Fix warning: uninitialized value $artist_type in numeric ne (!=) Fix warning: uninitialized value $ae in pattern match (m//) Fix warning: uninitialized value in string eq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MBS-10671
People are creating email-less accounts to mass-rate their favourite boy band. While that's mostly harmless, it's still stupid, and I can't see any reason why we should allow unverified users to submit ratings.
I haven't even tried to block submissions via the WS, since that doesn't seem very relevant for the kind of stuff we're trying to stop right now, but I guess we should do that too? Putting this up for now to make sure the general idea seems sound.