MBS-10365 (V): Convert entity lists to react-table #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvanzo
reviewed
Mar 17, 2020
5 tasks
reosarevok
force-pushed
the
MBS-10365-pt-5
branch
3 times, most recently
from
c636b17
to
2915370
Compare
yvanzo
approved these changes
Mar 18, 2020
reosarevok
force-pushed
the
MBS-10365-pt-5
branch
from
2915370
to
6f926e9
Compare
mwiencek
approved these changes
Mar 19, 2020
yvanzo
reviewed
Mar 20, 2020
|
You might want to cherry-pick yvanzo@2fd4a18 that patches |
This allows passing custom props to headers, so we can actually pass aria-label (and style) to the header for merge removals.
reosarevok
force-pushed
the
MBS-10365-pt-5
branch
from
601898c
to
07ba609
Compare
* `accessor` is mandatory in options for column with value, e.g., it can be used to sort non-paginated tables later on. * `Cell` defaults to returning `String(accessor(row))`. See https://github.com/tannerlinsley/react-table/blob/v7.0.0/docs/api/useTable.md#column-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1413
MBS-10365
Artist (the only one left) is a bit more annoying since the component is currently being shared between search results and normal lists. We might want to split that one for now, until we can figure out how to easily do search results with react-table.