MBS-10790: Convert historic MAC/SAC edits to React #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
force-pushed
the
MBS-10790
branch
2 times, most recently
from
6eb0a5c
to
63a2443
Compare
reosarevok
changed the title
These two were basically equivalent (the intended display is the same) so converted both templates into historic/ChangeReleaseArtist. Changes from the TT: Added a "change-release-artist" edit class. One of the two had none, the other had an actual relevant class, but I think it's worth combining them to avoid having two files with the same content otherwise. Uses HistoricReleaseList, so instead of "(unknown)" it will show "[removed]" for releases we're missing. This is consistent with other historical edits.
yvanzo
approved these changes
May 6, 2020
mwiencek
approved these changes
May 6, 2020
yvanzo
added a commit
that referenced
this pull request
May 6, 2020
* master: Update POT files using the production database Update translations from Transifex MBS-10792: Convert historic Change Artist Quality edit to React (#1482) MBS-10791: Convert historic Change RG edit to React MBS-10790: Convert historic MAC/SAC edits to React (#1480) MBS-10138: Fix guess case for titles finishing in "f" (#1495) Fix broken tests MBS-10396: Convert Edit Artist edit to React MBS-10805: Add support for more Amazon domains (#1490) Remove $c.user_exists from JS (#1485) MBS-10564: Display non-ASCII YouTube channel names too (#1492) MBS-10768: Fix crash in donation check for names with slashes (#1491) MBS-10803: Fix allowing Metal Archives artist URLs (#1497) MBS-10737: Allow The Session place URLs (#1498) MBS-10811: Convert historic Edit Relationship edit to React Remove unused imports Bump Flow to 0.124.0 Regenerate yarn.lock (again) Fix mistaken Flow typing, use addColonText MBS-10804: Remove redundant header with editor name (#1489) MBS-10775: Convert historic Add/Remove rel edits to React (#1471) Change historic edit name to match current one MBS-10773: Convert historic Change Release Quality edit to React Update React file location in comment MBS-10765: Convert historic Move Disc ID edit to React MBS-10765: Convert historic Add Disc ID edit to React MBS-10765: Convert historic Remove Disc ID edit to React MBS-10764: Convert historic Remove Label Alias edit to React (#1463) MBS-10762: Convert historic Remove Release edit to React MBS-10762: Convert Remove Releases edit to React MBS-10760: Convert Remove track edit to React (#1459) MBS-10641: Fix link to open edits for subcriptions (#1486) MBS-10761: Disallow YouTube links at wrong levels (#1460) Allow to set button value through FormSubmit Link to the doc page to be removed Replace .nowrap class with existing .actions Drop unusual brackets from action column MBS-9910: Convert WikiDoc admin create to React MBS-9910: Convert WikiDoc admin delete to React Allow to set button name through FormSubmit MBS-9910: Convert WikiDoc admin edit to React MBS-9910: Convert WikiDoc admin index to React Remove unused static/wikidocs dir after 6c00e92 Fix display_data types in EditReleaseGroup.js MBS-10400 Convert Edit Release Group edit to React (#1424) MBS-10748: Convert relationship type page to React Remove double // in imports Add GitHub first pull request welcome Link sponsor button to MeB donation page Add GitHub pull request template Link to contributing guidelines, add some hints Fix link to COPYING.md after feb3722 commit Move RelationshipTypesIndex to RelationshipTypesList Move relationship type page to a more sensible folder
yvanzo
added a commit
that referenced
this pull request
May 11, 2020
* beta: Update translations from Transifex Update POT files using the production database Update translations from Transifex MBS-10792: Convert historic Change Artist Quality edit to React (#1482) MBS-10791: Convert historic Change RG edit to React MBS-10790: Convert historic MAC/SAC edits to React (#1480) MBS-10138: Fix guess case for titles finishing in "f" (#1495) Fix broken tests MBS-10396: Convert Edit Artist edit to React MBS-10805: Add support for more Amazon domains (#1490) Remove $c.user_exists from JS (#1485) MBS-10564: Display non-ASCII YouTube channel names too (#1492) MBS-10768: Fix crash in donation check for names with slashes (#1491) MBS-10803: Fix allowing Metal Archives artist URLs (#1497) MBS-10737: Allow The Session place URLs (#1498) MBS-10811: Convert historic Edit Relationship edit to React Remove unused imports Bump Flow to 0.124.0 Regenerate yarn.lock (again) Fix mistaken Flow typing, use addColonText MBS-10804: Remove redundant header with editor name (#1489) MBS-10775: Convert historic Add/Remove rel edits to React (#1471) Change historic edit name to match current one MBS-10773: Convert historic Change Release Quality edit to React Update React file location in comment MBS-10765: Convert historic Move Disc ID edit to React MBS-10765: Convert historic Add Disc ID edit to React MBS-10765: Convert historic Remove Disc ID edit to React MBS-10764: Convert historic Remove Label Alias edit to React (#1463) MBS-10762: Convert historic Remove Release edit to React MBS-10762: Convert Remove Releases edit to React MBS-10760: Convert Remove track edit to React (#1459) MBS-10641: Fix link to open edits for subcriptions (#1486) MBS-10761: Disallow YouTube links at wrong levels (#1460) Allow to set button value through FormSubmit Link to the doc page to be removed Replace .nowrap class with existing .actions Drop unusual brackets from action column MBS-9910: Convert WikiDoc admin create to React MBS-9910: Convert WikiDoc admin delete to React Allow to set button name through FormSubmit MBS-9910: Convert WikiDoc admin edit to React MBS-9910: Convert WikiDoc admin index to React Remove unused static/wikidocs dir after 6c00e92 Fix display_data types in EditReleaseGroup.js MBS-10400 Convert Edit Release Group edit to React (#1424) MBS-10748: Convert relationship type page to React Remove double // in imports Add GitHub first pull request welcome Link sponsor button to MeB donation page Add GitHub pull request template Link to contributing guidelines, add some hints Fix link to COPYING.md after feb3722 commit Move RelationshipTypesIndex to RelationshipTypesList Move relationship type page to a more sensible folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-10790
These two were basically equivalent (the intended display is the same) so converted both templates into historic/ChangeReleaseArtist.
Changes from the TT:
Added a "change-release-artist" edit class. One of the two had none, the other had an actual relevant class, but I think it's worth combining them to avoid having two files with the same content otherwise.
Uses HistoricReleaseList, so instead of "(unknown)" it will show "[removed]" for releases we're missing. This is consistent with other historical edits.
On top of #1469