Sanitize IP hashes on staging servers #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
requested changes
Jun 4, 2020
mwiencek
approved these changes
Jun 5, 2020
In particular, it should be disabled on test.musicbrainz.org where everyone is admin and can access IP hashes.
|
Just fixed checking DBDefs keys instead of not yet defined stash entries in commit db5abe3. |
|
I'd say it's preferable to do that in both places even. |
|
To be addressed in #1555. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
IP hashes were stored and displayed to everyone on
test.musicbrainz.orgsince everyone has account admin permissions.Solution
Do not store IP hashes on staging servers running a sanitized database.
This is the same condition that is already used to inform that all passwords have been reset.
Action
DB_STAGING_SERVER_SANITIZEDto1fortest.musicbrainz.org