MBS-10890: Do not load language for works multiple times #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids languages being loaded for works each time load_for_works runs, which was making edit listings show "Russian, Russian, Russian" if the work was loaded three times in the list of edits. Now they won't be loaded again if the work already has languages loaded.
yvanzo
approved these changes
Jun 9, 2020
mwiencek
approved these changes
Jun 10, 2020
yvanzo
added a commit
that referenced
this pull request
Jun 10, 2020
* master: Update POT files using the production database MBS-1736: Block setting format on too early releases (#1111) MBS-10697 / MBS-10725 / MBS-10758 / MBS-10848: Smart links (#1544) MBS-6864: Drop all PUID-related code (#1551) Eslint fixes + typographic apostrophe MBS-4644: Show releases that have CAA images in lists MBS-10873: Load ACs for annotation edits (#1541) MBS-6532: Show work edits in recording / release history (#1165) MBS-10381: Disallow using a work language multiple times (#1559) MBS-10892: Show private collaborated-on collections on sidebars (#1565) MBS-8625: release data quality icons (#1556) Fix invalid <div> inside <span> Compile static resources in the docker images Remove DBDefs dependency from webpack config Make DBDefs JS external from build Add DBDefs Flow defs Cleanup dbdefs_to_js conversion Remove unused variable MBS-10893: Document selecting artist for CD lookup (#1563) MBS-10890: Do not load language for works multiple times (#1562) Fix error message about Instagram `/explore` URLs (#1566) MBS-10821: Remove orphaned recordings from collections for deletion (#1512) MBS-10862: Report "CatNoLooksLikeLabelCode" (#1548) MBS-9931: Fail gracefully when trying to remove example rel MBS-9340: Only allow mul and zxx as the only work language Set cacheDirectory: true for babel-loader Set preset-env target to node version on server Bump babel-loader to 8.1.0 Fix multiple imports on one line Upgrade core-js to v3 and set useBuiltIns: 'usage' Fix format_editnote running on localized note URL MBS-10186: Check for missing CD TOC on SetTrackLengths (#1511) Upgrade all babel deps Bump mutate-cow to 4.0.2 MBS-10891: Replace Magic MP3 Tagger link with AudioRanger (#1560) Escape ', ", `, and GIT_MSG in GIT_MSG (#1557) MBS-10885: Fix error when URL has been removed (#1553) Eslint fixes MBS-10887: Fix country/date text CSS alignment (#1554) Refactor 435310d: Check DBDefs instead of stash (#1555) Fix TypeError when changing relationship type MBS-10856: Trim whitespace on relationship credits (#1545) Fix non-sanitized staging server is beta not test Disable IP hashes on sanitized staging server MBS-10836: Fix edit / remove collection links (#1550) Drop FUNDING file made obsolete by '.github' repo MBS-10882: Remove accidental duplicate push (#1547) Rename AddStandaloneRecordingProps and add separate props type $EDIT_RECORDING_CREATE artist_credit is not optional Fix bracket indentation $EDIT_RECORDING_CREATE name is not optional MBS-10771: Block tagging for unverified users (#1504) MBS-10877: Display source URLs in the relationship editor dialog MBS-10867: Fix "entity not in the entities array" MBS-10469: Add 10 minute delay to shown CAA on front page (#1540) Only print recording name instead of linking recording twice MBS-10393: Convert Add Standalone Recording edit to React Add react-dom libdefs from flow-typed Document $c-in-JS a bit more Enable types-first mode in Flow Add Flow types to AreaWithContainmentLink.js Add Flow types to AreaContainmentLink.js Add Flow types to 404.js Add Flow types to Footer.js Pass $c to all server-rendered components Add Flow types to ExternalLinks.js Bump Flow to 0.125.1 Fix typo preventing to store alert_mtime on beta Add colon instead of brackets to row header
yvanzo
added a commit
that referenced
this pull request
Jun 15, 2020
* beta: Update translations from Transifex Fix warning about masked variable since c1faa8b Update POT files using the production database MBS-1736: Block setting format on too early releases (#1111) MBS-10697 / MBS-10725 / MBS-10758 / MBS-10848: Smart links (#1544) MBS-6864: Drop all PUID-related code (#1551) Eslint fixes + typographic apostrophe MBS-4644: Show releases that have CAA images in lists MBS-10873: Load ACs for annotation edits (#1541) MBS-6532: Show work edits in recording / release history (#1165) MBS-10381: Disallow using a work language multiple times (#1559) MBS-10892: Show private collaborated-on collections on sidebars (#1565) MBS-8625: release data quality icons (#1556) Fix invalid <div> inside <span> Compile static resources in the docker images Remove DBDefs dependency from webpack config Make DBDefs JS external from build Add DBDefs Flow defs Cleanup dbdefs_to_js conversion Remove unused variable MBS-10893: Document selecting artist for CD lookup (#1563) MBS-10890: Do not load language for works multiple times (#1562) Fix error message about Instagram `/explore` URLs (#1566) MBS-10821: Remove orphaned recordings from collections for deletion (#1512) MBS-10862: Report "CatNoLooksLikeLabelCode" (#1548) MBS-9931: Fail gracefully when trying to remove example rel MBS-9340: Only allow mul and zxx as the only work language Set cacheDirectory: true for babel-loader Set preset-env target to node version on server Bump babel-loader to 8.1.0 Fix multiple imports on one line Upgrade core-js to v3 and set useBuiltIns: 'usage' Fix format_editnote running on localized note URL MBS-10186: Check for missing CD TOC on SetTrackLengths (#1511) Upgrade all babel deps Bump mutate-cow to 4.0.2 MBS-10891: Replace Magic MP3 Tagger link with AudioRanger (#1560) Escape ', ", `, and GIT_MSG in GIT_MSG (#1557) MBS-10885: Fix error when URL has been removed (#1553) Eslint fixes MBS-10887: Fix country/date text CSS alignment (#1554) Refactor 435310d: Check DBDefs instead of stash (#1555) Fix TypeError when changing relationship type MBS-10856: Trim whitespace on relationship credits (#1545) Fix non-sanitized staging server is beta not test Disable IP hashes on sanitized staging server MBS-10836: Fix edit / remove collection links (#1550) Drop FUNDING file made obsolete by '.github' repo MBS-10882: Remove accidental duplicate push (#1547) Rename AddStandaloneRecordingProps and add separate props type $EDIT_RECORDING_CREATE artist_credit is not optional Fix bracket indentation $EDIT_RECORDING_CREATE name is not optional MBS-10771: Block tagging for unverified users (#1504) MBS-10877: Display source URLs in the relationship editor dialog MBS-10867: Fix "entity not in the entities array" MBS-10469: Add 10 minute delay to shown CAA on front page (#1540) Only print recording name instead of linking recording twice MBS-10393: Convert Add Standalone Recording edit to React Add react-dom libdefs from flow-typed Document $c-in-JS a bit more Enable types-first mode in Flow Add Flow types to AreaWithContainmentLink.js Add Flow types to AreaContainmentLink.js Add Flow types to 404.js Add Flow types to Footer.js Pass $c to all server-rendered components Add Flow types to ExternalLinks.js Bump Flow to 0.125.1 Fix typo preventing to store alert_mtime on beta Add colon instead of brackets to row header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-10890
This avoids languages being loaded for works each time load_for_works runs, which was making edit listings show "Russian, Russian, Russian" if the work was loaded three times in the list of edits. Now they won't be loaded again if the work already has languages loaded.
Thanks @mwiencek for the suggestion.