MBS-10907: Set white background color to HTML body #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, background color was set for the main content only. Header and footer were lesser readable when the browser’s background color was not white as well. This patch defines the background for HTML body instead of main content.
reosarevok
approved these changes
Jun 18, 2020
mwiencek
approved these changes
Jun 22, 2020
yvanzo
added a commit
that referenced
this pull request
Jun 24, 2020
* master: Update POT files using the production database Update translations from Transifex MBS-10908: Stop recording-of rel edits showing for all recordings of work (#1574) MBS-10736: Add Napster autoselect + sidebar (#1447) MBS-10825: Fix Muziekweb cleanup, add work support (#1517) MBS-10903: Update Operabase cleanup / validation (#1571) Move label code message into renderToStaticMarkup call Remove now unused macro display_relationship MBS-10802: Improve alignment of Reorder Relationships table MBS-10801: Convert Reorder Relationships edit to React MBS-10894: Add LC code in help bubble after adding label in release editor MBS-10895: Add report about conflicting discids on the same medium Add subPath property to entity links in reports Hide Artist column in RecordingsWithFutureDates report MBS-10770: add report about relationships with future dates MBS-10907: Set white background color to HTML body (#1573) Add @flow strict to more files Bump Flow to 0.126.1 Fix warning about masked variable since c1faa8b MBS-10777: Convert Remove Relationship edit to React MBS-10777: Convert Add Relationship edit to React
yvanzo
added a commit
that referenced
this pull request
Jun 29, 2020
* beta: Update translations from Transifex Update POT files using the production database Update translations from Transifex MBS-10908: Stop recording-of rel edits showing for all recordings of work (#1574) MBS-10736: Add Napster autoselect + sidebar (#1447) MBS-10825: Fix Muziekweb cleanup, add work support (#1517) MBS-10903: Update Operabase cleanup / validation (#1571) Move label code message into renderToStaticMarkup call Remove now unused macro display_relationship MBS-10802: Improve alignment of Reorder Relationships table MBS-10801: Convert Reorder Relationships edit to React MBS-10894: Add LC code in help bubble after adding label in release editor MBS-10895: Add report about conflicting discids on the same medium Add subPath property to entity links in reports Hide Artist column in RecordingsWithFutureDates report MBS-10770: add report about relationships with future dates MBS-10907: Set white background color to HTML body (#1573) Add @flow strict to more files Bump Flow to 0.126.1 Fix warning about masked variable since c1faa8b MBS-10777: Convert Remove Relationship edit to React MBS-10777: Convert Add Relationship edit to React
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MBS-10907
Previously, background color was set for the main content only. Header and footer were lesser readable when the browser’s background color was not white as well.
Solution
This patch defines the background for HTML body instead of main content.