MBS-11000: Avoid "Edit release group" edit ISE when comment is null #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
added
the
Regression/Beta
yvanzo
approved these changes
Aug 3, 2020
mwiencek
requested changes
Aug 3, 2020
reosarevok
force-pushed
the
MBS-11000
branch
from
ea662d3
to
d0b7128
Compare
mwiencek
approved these changes
Sep 2, 2020
yvanzo
added a commit
that referenced
this pull request
Sep 3, 2020
* master: Update POT files using the production database Fix localization of AcousticBrainz analysis Update translations from Transifex Improvements to AddRelationshipAttribute MBS-11052: Convert Edit Relationship Attribute edit to React Generalize IntentionallyRawIcon (#1672) Eslint auto-fixes for quote-props (#1671) MBS-11000: Avoid ISE when comment is null (#1627) Bump Flow to 0.133.0 Remove no longer needed defaulting MBS-11034: Convert Remove medium edit to React MBS-11039: Don't use entity id as key for seriesItemNumbers (#1656) Add missing full stop to avoid string duplication. MBS-11041: Make ModBot leave a note on autoremoval edits (#1654) MBS-11043: Add offiziellecharts.de to the otherdbs whitelist (#1655) MBS-11014: Add context to DuplicateViolation on rels editor (#1631) MBS-10941: Rename XML Web Service into "MusicBrainz API" Remove "nat" as a WS release (group) type Support GET requests in ssssss.psgi (#1652) Rename "get"-type function for clarity Add "global" hasOwnProp utility Rename variable for clarity Eradicate humor MBS-10972: Convert Add Instrument edit to React (#1602) Move attribute error calculation into method for clarity Add compactMap utility Guard against some undef values in series edit form Remove lodash Replace _.uniqueId Remove _.identity Remove _.noop Remove _.once Replace _.head, _.last Remove _.isEmpty Replace _.escape with he.escape Replace _.capitalize, _.upperFirst, _.kebabCase Remove _.result Replace _.range Replace lodash/debounce Replace lodash/defaults with object spreads Replace _.isEqual, _.isEqualWith Remove use of lodash/partition Remove _.without Replace _.uniqBy, _.sortedUniqBy Remove _.mapValues Replace _.keyBy Replace lodash/groupBy Remove remaining uses of _.each Remove _.union, _.unionBy Replace _.transform with native reduce Remove _.sortBy Remove _.intersection Remove _.uniq Remove _.cloneDeep Specify all lodash imports Remove _.throttle Remove _.bindAll Remove _.countBy Remove _.sortedIndex Replace _.sumBy with native reduce Remove _.zip Remove useless use of _.isPlainObject Replace _.pick Replace _.repeat with native method Replace _.times Replace _.tail with slice(1) Replace _.padStart with native method Replace _.max with Math.max Replace _.isObject with typeof check Replace _.invokeMap with native map Replace _.flatten with native methods Replace _.isFinite with native method Remove _.size Replace _.includes with native method Replace _.get Replace _.isFunction with typeof check Replace _.flow with arrow function Replace _.initial with native slice Replace _.lastIndexOf with native method Replace _.take with native slice Replace _.trimEnd with native method Remove useless use of _.isNaN Replace _.every with native method Replace _.compact with filter(Boolean) Replace _.indexOf with native method Replace _.isArray with native method Replace _.clone with object spreads Replace _.reduce with native method Replace _.has with hasOwnProperty Replace _.reject with negated filter Replace _.delay with setTimeout Replace _.defer with setTimeout 1 Replace _.isString with typeof checks Remove useless use of _.isNumber Replace _.values with Object.values Replace _.keys with Object.keys Replace _.toArray with Array.from Replace _.partial, _.partialRight, _.wrap with arrow functions Replace _.bind with native method Remove _.omit Replace _.some with native method Replace _.filter with native method Replace _.map with native method Replace _.find, _.findIndex with native methods Replace _.each Remove lodash method chaining Retitle AcousticBrainz section in the sidebar Replace cases of _ being as an apply thisObj Remove global uses of _ Remove unused vars Move "too short year" JS out of TT Add missing globals to script/check_eslint_rule Import MB in tests/release-editor/actions.js Fix Flow error in hydrate.js MBS-11050: Convert Edit URL edit to React (#1664) MBS-11051: Convert Edit Artist Credit edit to React (#1665) MBS-11048: Convert Edit Area edit to React (#1661) MBS-11032: Convert Add medium edit to React MBS-11032: Convert medium/tracklist.tt to React Add missing copyright header Changes to make files @flow strict-local Minor changes to make files @flow strict-local Use @flow strict-local when no changes are needed Add and improve flow typing Move hydrate props from attribute to <script> Include sanitized $c data only once on the page Delete $c from data-props Allow using nonEmpty with ProvidePlugin MBS-11044: Drop references to TOBEDELETED edit status (#1657) MBS-10916: Add help message about AcousticBrainz-generated data MBS-10916: Fix ambiguity display of tonal key Remove unused UUID_REGEXP_STR constant Bump mutate-cow to 4.0.3 Remove genre_map from sanitized context Consistently use split="-" for date diffs Use WordDiff instead of passing split "\s+" MBS-10916: Use more precise AcousticBrainz API MBS-10986: Convert require_note to React MBS-10986: Convert cannot_vote to React Better messages for CannotCancelEdit MBS-10986: Convert cannot_approve to React MBS-7409: Make "cannot attach discid" more obvious MBS-10916: Display AcousticBrainz info in the Recording sidebar MBS-10986: Convert cannot_cancel to React
yvanzo
added a commit
that referenced
this pull request
Sep 7, 2020
* beta: MBS-11077: Update sort parameter for load_display_reviews (#1684) Update translations from Transifex Fix unspecified RG type (#1678) Update POT files using the production database Use snake_case for substitution arg name Remove unnecessary imports from common.js Add fetch polyfill Disable core-js on plugin-transform-runtime Transpile Jed, mutate-cow for IE11 Add shared module for babel-ignored files Update POT files using the production database Fix localization of AcousticBrainz analysis Update translations from Transifex Improvements to AddRelationshipAttribute MBS-11052: Convert Edit Relationship Attribute edit to React Generalize IntentionallyRawIcon (#1672) Eslint auto-fixes for quote-props (#1671) MBS-11000: Avoid ISE when comment is null (#1627) Bump Flow to 0.133.0 Remove no longer needed defaulting MBS-11034: Convert Remove medium edit to React MBS-11039: Don't use entity id as key for seriesItemNumbers (#1656) Add missing full stop to avoid string duplication. MBS-11041: Make ModBot leave a note on autoremoval edits (#1654) MBS-11043: Add offiziellecharts.de to the otherdbs whitelist (#1655) MBS-11014: Add context to DuplicateViolation on rels editor (#1631) MBS-10941: Rename XML Web Service into "MusicBrainz API" Remove "nat" as a WS release (group) type Support GET requests in ssssss.psgi (#1652) Rename "get"-type function for clarity Add "global" hasOwnProp utility Rename variable for clarity Eradicate humor MBS-10972: Convert Add Instrument edit to React (#1602) Move attribute error calculation into method for clarity Add compactMap utility Guard against some undef values in series edit form Remove lodash Replace _.uniqueId Remove _.identity Remove _.noop Remove _.once Replace _.head, _.last Remove _.isEmpty Replace _.escape with he.escape Replace _.capitalize, _.upperFirst, _.kebabCase Remove _.result Replace _.range Replace lodash/debounce Replace lodash/defaults with object spreads Replace _.isEqual, _.isEqualWith Remove use of lodash/partition Remove _.without Replace _.uniqBy, _.sortedUniqBy Remove _.mapValues Replace _.keyBy Replace lodash/groupBy Remove remaining uses of _.each Remove _.union, _.unionBy Replace _.transform with native reduce Remove _.sortBy Remove _.intersection Remove _.uniq Remove _.cloneDeep Specify all lodash imports Remove _.throttle Remove _.bindAll Remove _.countBy Remove _.sortedIndex Replace _.sumBy with native reduce Remove _.zip Remove useless use of _.isPlainObject Replace _.pick Replace _.repeat with native method Replace _.times Replace _.tail with slice(1) Replace _.padStart with native method Replace _.max with Math.max Replace _.isObject with typeof check Replace _.invokeMap with native map Replace _.flatten with native methods Replace _.isFinite with native method Remove _.size Replace _.includes with native method Replace _.get Replace _.isFunction with typeof check Replace _.flow with arrow function Replace _.initial with native slice Replace _.lastIndexOf with native method Replace _.take with native slice Replace _.trimEnd with native method Remove useless use of _.isNaN Replace _.every with native method Replace _.compact with filter(Boolean) Replace _.indexOf with native method Replace _.isArray with native method Replace _.clone with object spreads Replace _.reduce with native method Replace _.has with hasOwnProperty Replace _.reject with negated filter Replace _.delay with setTimeout Replace _.defer with setTimeout 1 Replace _.isString with typeof checks Remove useless use of _.isNumber Replace _.values with Object.values Replace _.keys with Object.keys Replace _.toArray with Array.from Replace _.partial, _.partialRight, _.wrap with arrow functions Replace _.bind with native method Remove _.omit Replace _.some with native method Replace _.filter with native method Replace _.map with native method Replace _.find, _.findIndex with native methods Replace _.each Remove lodash method chaining Retitle AcousticBrainz section in the sidebar Replace cases of _ being as an apply thisObj Remove global uses of _ Remove unused vars Move "too short year" JS out of TT Add missing globals to script/check_eslint_rule Import MB in tests/release-editor/actions.js Fix Flow error in hydrate.js MBS-11050: Convert Edit URL edit to React (#1664) MBS-11051: Convert Edit Artist Credit edit to React (#1665) MBS-11048: Convert Edit Area edit to React (#1661) MBS-11032: Convert Add medium edit to React MBS-11032: Convert medium/tracklist.tt to React Add missing copyright header Changes to make files @flow strict-local Minor changes to make files @flow strict-local Use @flow strict-local when no changes are needed Add and improve flow typing Move hydrate props from attribute to <script> Include sanitized $c data only once on the page Delete $c from data-props Allow using nonEmpty with ProvidePlugin MBS-11044: Drop references to TOBEDELETED edit status (#1657) MBS-10916: Add help message about AcousticBrainz-generated data MBS-10916: Fix ambiguity display of tonal key Remove unused UUID_REGEXP_STR constant Bump mutate-cow to 4.0.3 Remove genre_map from sanitized context Consistently use split="-" for date diffs Use WordDiff instead of passing split "\s+" MBS-10916: Use more precise AcousticBrainz API MBS-10986: Convert require_note to React MBS-10986: Convert cannot_vote to React Better messages for CannotCancelEdit MBS-10986: Convert cannot_approve to React MBS-7409: Make "cannot attach discid" more obvious MBS-10916: Display AcousticBrainz info in the Recording sidebar MBS-10986: Convert cannot_cancel to React
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-11000