MBS-11069: Fix diff highlighting of white spaces #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browsers omit the rendering of trailing white spaces by default when they wrap content to fit the width of the containing element. In case the white spaces are part of the highlighted differences, they should be rendered before line wraps as well.
|
Thanks for opening your first pull request for MusicBrainz Server, and welcome to our community! 🎉 |
yvanzo
approved these changes
Sep 14, 2020
mwiencek
approved these changes
Sep 14, 2020
|
Congratulations on your first merged pull request for MusicBrainz Server! 🎉 |
yvanzo
added a commit
that referenced
this pull request
Sep 16, 2020
* master: Update POT files using the production database Update translations from Transifex MBS-7473: Allow specifying a release MBID when attaching a CD TOC (#1387) MBS-11065: Only block smart links if they have a path (#1677) MBS-11017: Normalize IMSLP to HTTPS and add validation (#1635) MBS-11068: Block redirect links: page.link (#1680) MBS-11101: Fix series not using seriesOrderingFunc (#1695) MBS-10835: Don't send verification mail if address in use (#1679) Eslint indent auto-fixes Bump all ESLint dependencies Bump all Babel dependencies Ignore JSXElement, ArrowFunctionExpression in indent rule MBS-11062: Link basic how-tos from the front page (#1674) MBS-11098: Fix validating Big Cartel URL for label (#1693) MBS-10880: Reset RGs in cache when first date changes (#1683) Fix innocuous warnings caused by Edit release edit (#1694) s/dependancies/dependencies/g Document CAA-indexer's upload_url config Test for sending access_token via POST body MBS-7485, MBS-11058: OAuth token revokation MBS-11058: Support response_mode=form_post for /oauth2/authorize generate_token uses 192 bits MBS-11058: Implement PKCE (RFC 7636) for OAuth2 MBS-11086: Add icon for tabs with errors in release editor (#1689) MBS-11061: Disallow MusicBrainz URLs in relationships (#1675) MBS-9769: Cache 'added entities' editor stats in redis MBS-9769: Add 'entities added' stats on editor profile MBS-11058: Set Referrer-Policy on /oauth2/authorize Add CSP headers to other account forms Remove unused Minimal attribute MBS-11058: Set Content-Security-Policy on /oauth2/authorize MBS-11058: Set X-Frame-Options: DENY on /oauth2/authorize Fix backwards tests MBS-11058: Disallow same parameter twice in OAuth2 endpoints MBS-11069: Fix diff highlighting of white spaces (#1691) Bump http-proxy to 1.18.1 Amend d5e3f84 to fix localizable string (#1690) MBS-10961: Block musics.link smart links MBS-11007: Block rb.gy URL shortener MBS-11008: Block bstlnk.to smart links MBS-11001: Block push.fm smart links Fix incorrect shortener path (backl.ink)
kellnerd
added a commit
to kellnerd/musicbrainz-server
that referenced
this pull request
Sep 16, 2020
This is a regression of metabrainz#1691 which changed the style of highlighted differences to always render white spaces inside their `<span>` elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MBS-11069
Browsers omit the rendering of trailing white spaces by default when they wrap content to fit the width of the containing element. In case the white spaces are part of the highlighted differences, they should be rendered before line wraps as well.
Solution
Change the behavior of white spaces for diffs via CSS, see https://developer.mozilla.org/en-US/docs/Web/CSS/white-space
Action
Someone should verify this change on a test server as I haven't installed the server on my machine (Hopefully I've added this to the correct stylesheet). I only verified that this works by dynamically changing the CSS of the example that was given for the ticket using the Firefox development tools.