MBS-11114: Allow track times to be unset #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
commented
Sep 24, 2020
| @@ -159,7 +159,7 @@ class Track { | |||
|
|
|||
| var newLength = utils.unformatTrackLength(length); | |||
|
|
|||
| if (!newLength) { | |||
| if (Number.isNaN(newLength)) { | |||
There was a problem hiding this comment.
This previously used https://lodash.com/docs/4.17.15#isNaN which is based on Number.isNaN, not isNaN:
Note: This method is based on Number.isNaN and is not the same as global isNaN which returns true for undefined and other non-number values.
0d45452 broke this by incorrectly removing the "useless" isNaN check, which it turns out was not "useless." The result of `unformatTrackLength` is null when the length is empty, so the bug is that we'd bail out too early with the new check and fail to set `this.length(newLength)`. The result is only NaN when the input can't be parsed. A test is now added.
mwiencek
added
Bug
reosarevok
pushed a commit
to reosarevok/musicbrainz-server
that referenced
this pull request
Oct 7, 2020
0d45452 broke this by incorrectly removing the "useless" isNaN check, which it turns out was not "useless." The result of `unformatTrackLength` is null when the length is empty, so the bug is that we'd bail out too early with the new check and fail to set `this.length(newLength)`. The result is only NaN when the input can't be parsed. A test is now added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0d45452 broke this by incorrectly removing the "useless" isNaN check, which it turns out was not "useless." The result of
unformatTrackLengthis null when the length is empty, so the bug is that we'd bail out too early with the new check and fail to setthis.length(newLength). The result is only NaN when the input can't be parsed. A test is now added.