MBS-11514 / MBS-11515 / MBS-11516 / MBS-11517: Use React.useContext in more places rather than passing $c around #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
force-pushed
the
MBS-11303
branch
3 times, most recently
from
75558a2
to
6ae8f80
Compare
reosarevok
changed the title
yvanzo
approved these changes
Mar 23, 2021
mwiencek
reviewed
Mar 24, 2021
root/collection/CollectionIndex.js
Outdated
| @@ -161,8 +158,9 @@ const listPicker = ( | |||
|
|
|||
| const CollectionIndex = (props: Props): | |||
| React.Element<typeof CollectionLayout> => { | |||
| const $c = React.useContext(CatalystContext); | |||
There was a problem hiding this comment.
I think it's better not to do this for top-level components, since it's always passed as a prop in that case: https://github.com/metabrainz/musicbrainz-server/blob/b036579/root/server/response.js#L100
So it's actually simpler to just use the prop here. I'm not sure if this is the only example in this PR.
There was a problem hiding this comment.
I rechecked, I think this was the only one. Amended.
reosarevok
force-pushed
the
MBS-11303
branch
2 times, most recently
from
9bc055d
to
04d3827
Compare
There's also no need to pass the different bits of stash separately. It's much more clean to just pass entity and assign the rest from context on the component.
mwiencek
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements MBS-11514 / MBS-11515 / MBS-11516 / MBS-11517
Some big chunks (like Layout) left for a second PR to avoid making this huge. Reports bits done in #1787 since that already refactors the whole thing.
This shaves some lines, but more importantly it makes it easier to understand and follow and avoids passing $c down several components just to reach the one N steps down the line.
I'd suggest reviewing with the whitespace ignore on, since most changes other than just the $c bit itself are to indent some components because of adding return () to them.
Tested by navigating around locally, but not extensively - plus Flow to ensure I didn't keep passing $c where I shouldn't anymore.