Fix Catalyst warning: id is missing in edit previews #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were always expecting an ID, but edit previews don't yet have an edit ID. Since having separate types for edits and previews would probably be too complicated (many places use ...EditT and whatnot) we just make id possibly null and ensure we specify it is being passed where we use it and know for sure we are passing it.
mwiencek
approved these changes
Apr 12, 2021
yvanzo
approved these changes
Apr 13, 2021
reosarevok
added a commit
that referenced
this pull request
Apr 14, 2021
* master: Update POT files using the production database Update translations from Transifex MBS-9631: Add 1200px to available image sizes (#2054) Remove unused $c variable MBS-11582: Add a sortname method for instrument guess case (#2065) Fix Catalyst warning: don't try undef linktype id to access $loaded (#2062) MBS-11527: Block smart links: music.indiefy.net (#2016) MBS-11533: Block smart links: snd.click (#2023) Add keys to EditReleaseEvents to stop warning (#2063) Fix Catalyst warning: don't try using undef to access hash (#2059) Fix Catalyst warning: ensure parent format id is not undef (#2060) MBS-11564: Don't block Niconi Commons links with Nicovideo cleanup (#2044) MBS-11500: Do not pass GID of removed release to avoid linking (#2035) MBS-11563: Invalidate entity_link_type_counts on relationship inserts (#2047) Fix Catalyst warning: don't pass undef review text to markdown (#2061) Fix Catalyst warning: id is missing in edit previews (#2057) MBS-10534: Handle DNB links (#2030) MBS-11581: Skip darkened releases on Artwork->load_for_release_groups MBS-11581: Don't load darkened cover art for Set Cover Art form MBS-11524: Disallow https://*.bandcamp.com/ URLs at release and recording level (#2050) MBS-11566: Ensure consistent ordering of appearances sections Bump Flow to 0.148.0 Optimize help message and fix CI MBS-9833: Add relationship style guide link MBS-11516: Use React.useContext in [Entity]List MBS-11514: Use React.useContext in [Entity]Sidebar MBS-11514: Use React.useContext in SidebarTags MBS-11514: Use React.useContext in SubscriptionLinks MBS-11517: Use React.useContext in MergeHelper MBS-11515: Use React.useContext in Footer MBS-11515: Use React.useContext in TopMenu/BottomMenu MBS-11515: Use React.useContext in Head MBS-11514: Use React.useContext in CollectionLinks MBS-11514: Use React.useContext in AnnotationLinks MBS-11514: Use React.useContext in EditLinks
reosarevok
added a commit
that referenced
this pull request
Apr 19, 2021
* beta: Update POT files using the production database Update translations from Transifex MBS-11583: Use sanitized context in hydrated component (#2066) MBS-11569: Limit entity types when creating collection from sidebar (#2048) Update POT files using the production database Update translations from Transifex MBS-9631: Add 1200px to available image sizes (#2054) Remove unused $c variable MBS-11582: Add a sortname method for instrument guess case (#2065) Fix Catalyst warning: don't try undef linktype id to access $loaded (#2062) MBS-11527: Block smart links: music.indiefy.net (#2016) MBS-11533: Block smart links: snd.click (#2023) Add keys to EditReleaseEvents to stop warning (#2063) Fix Catalyst warning: don't try using undef to access hash (#2059) Fix Catalyst warning: ensure parent format id is not undef (#2060) MBS-11564: Don't block Niconi Commons links with Nicovideo cleanup (#2044) MBS-11500: Do not pass GID of removed release to avoid linking (#2035) MBS-11563: Invalidate entity_link_type_counts on relationship inserts (#2047) Fix Catalyst warning: don't pass undef review text to markdown (#2061) Fix Catalyst warning: id is missing in edit previews (#2057) MBS-10534: Handle DNB links (#2030) MBS-11581: Skip darkened releases on Artwork->load_for_release_groups MBS-11581: Don't load darkened cover art for Set Cover Art form MBS-11552: Add validation for Classical Archives links MBS-11542: Allow and cleanup new Classical Archives links MBS-11524: Disallow https://*.bandcamp.com/ URLs at release and recording level (#2050) MBS-11566: Ensure consistent ordering of appearances sections Bump Flow to 0.148.0 Optimize help message and fix CI MBS-9833: Add relationship style guide link MBS-11516: Use React.useContext in [Entity]List MBS-11514: Use React.useContext in [Entity]Sidebar MBS-11514: Use React.useContext in SidebarTags MBS-11514: Use React.useContext in SubscriptionLinks MBS-11517: Use React.useContext in MergeHelper MBS-11515: Use React.useContext in Footer MBS-11515: Use React.useContext in TopMenu/BottomMenu MBS-11515: Use React.useContext in Head MBS-11514: Use React.useContext in CollectionLinks MBS-11514: Use React.useContext in AnnotationLinks MBS-11514: Use React.useContext in EditLinks
mwiencek
added a commit
that referenced
this pull request
May 11, 2021
* production: Allow overriding REPLICATION_TYPE in admin/InitDb.pl Update POT files using the production database Update translations from Transifex Increase CAA bucket creation timeout to 30s Update POT files using the production database Update translations from Transifex MBS-11598: Do not generate image link if we don't have a suffix (#2069) MBS-11590: Standardize display of empty fields in cover art edits (#2076) MBS-11587: Block smart links: hypel.ink (#2077) MBS-11612: Restore link to genre/delete to genre sidebar MBS-11620: Sort results of admin's search_by_email tool newest first MBS-11619: Ignore periods and +tags in e-mail admin searches MBS-11604: Add genre name to genre index title (#2071) MBS-11611: Do not keep/add trailing slash in OC ReMix URLs (#2072) MBS-10899: Report for releases with catnos that look like ISRCs (#2067) Ensure CAA item ownership during upload process Check for valid mime_type in /ws/js/cover-art-upload Check for login in /ws/js/cover-art-upload Update POT files using the production database Put l() string on one line to avoid \n on .pot Update translations from Transifex MBS-9259: Add help section for the track parser (#2046) Removing no longer needed '' defaults MBS-11550: Move PostParameters to static/scripts for translation (#2032) MBS-11571: Warn about e-mail as a username (#2049) MBS-11573: Load collections for ratings sidebars (#2052) MBS-1588: Better errors for invalid CD TOC (#2056) MBS-9251: Display ended places differently on the map (#2051) MBBE-31: Remove now unneeded old RA checks (#2028) MBS-11546: Allow Resident Advisor /exchange URLs for releases (#2025) MBS-11603: Finetune DNB validation (#2070) Update POT files using the production database Update translations from Transifex Use addColonText for Tracklist header MBS-11583: Use sanitized context in hydrated component (#2066) Ensure privileges are encoded as a number MBS-11569: Limit entity types when creating collection from sidebar (#2048) Update POT files using the production database Update translations from Transifex MBS-9631: Add 1200px to available image sizes (#2054) Remove unused $c variable MBS-11582: Add a sortname method for instrument guess case (#2065) Fix Catalyst warning: don't try undef linktype id to access $loaded (#2062) MBS-11527: Block smart links: music.indiefy.net (#2016) MBS-11533: Block smart links: snd.click (#2023) Add keys to EditReleaseEvents to stop warning (#2063) Fix Catalyst warning: don't try using undef to access hash (#2059) Fix Catalyst warning: ensure parent format id is not undef (#2060) MBS-11564: Don't block Niconi Commons links with Nicovideo cleanup (#2044) MBS-11500: Do not pass GID of removed release to avoid linking (#2035) Fix catalyst warning: don't try to trim/sanitize undef "strings" MBS-11563: Invalidate entity_link_type_counts on relationship inserts (#2047) Fix Catalyst warning: don't pass undef review text to markdown (#2061) Fix Catalyst warning: id is missing in edit previews (#2057) MBS-10534: Handle DNB links (#2030) MBS-11581: Skip darkened releases on Artwork->load_for_release_groups MBS-11581: Don't load darkened cover art for Set Cover Art form MBS-11552: Add validation for Classical Archives links MBS-11542: Allow and cleanup new Classical Archives links MBS-11524: Disallow https://*.bandcamp.com/ URLs at release and recording level (#2050) MBS-11566: Ensure consistent ordering of appearances sections Pass public editor privs when converting editor to JSON Update the link to edit search help MBS-9376: Indicate that edit searches can be bookmarked + link docs MBS-11559: Specify tracklist is empty in Remove medium edits Bump Flow to 0.148.0 Update POT files using the production database Update translations from Transifex Revert "MBS-11367: Disable browser autocomplete for tags when non-empty" Increase the default relationship page limit sizes (#2031) Update POT files using the production database Update translations from Transifex MBS-11531 (II): Pass $c to load_filtered call (#2027) Optimize help message and fix CI MBS-9833: Add relationship style guide link Update POT files using the production database Update translations from Transifex MBS-11320 / MBS-11321: Don't add new medium if empty medium existed (#1857) MBS-11531: Pass $c to _load in load_filtered MBS-9851: Allow finding edits w/ edit notes by not original editor MBS-11525: Link to downvoted per-entity list when seeing downvotes Restore original class names for collapse/expand-medium MBS-11530: Avoid common/MB/release code running on these MBS-11476: Don't show own open edits in /edit/open MBS-11373: Overwrite empty dates in relationship merges MBS-11386: Load area containment for indexed search MBS-11473: Don't try to filter open edits for user if logged out MBS-11442: Adding tags on add-cover-art page disables submit (#1983) MBS-8807: Provide collection data to subscribers sub-pages MBS-11538: Collections data missing in some sidebars MBS-11222: Add a report for releases with media without a tracklist MBS-11367: Disable browser autocomplete for tags when non-empty MBS-11467: Use sort name to order lists of artists for tags MBS-9543: Avoid false negative for string '0' MBS-9349: Add Pinterest links to the sidebar MBS-11510: Stop overwriting titles in disableBecauseDiscIDs Update POT files using the production database Update translations from Transifex MBS-11513: Use React.useContext in reports MBS-11516: Use React.useContext in [Entity]List MBS-11514: Use React.useContext in [Entity]Sidebar MBS-11514: Use React.useContext in SidebarTags MBS-11514: Use React.useContext in SubscriptionLinks MBS-11517: Use React.useContext in MergeHelper MBS-11515: Use React.useContext in Footer MBS-11515: Use React.useContext in TopMenu/BottomMenu MBS-11515: Use React.useContext in Head MBS-11514: Use React.useContext in CollectionLinks MBS-11514: Use React.useContext in AnnotationLinks MBS-11514: Use React.useContext in EditLinks Output work recordings sitemaps Simplify the user tag pages UI Add link back to UserTag from UserTagEntity More specific headers / texts depending on entity type MBS-10690: Convert user/tags.tt to React MBS-1870 / MBS-8477 / MBS-10341: User tag page improvements Use formatCount directly instead of through exp.l MBS-11455: Hide view links on stats when logged out MBS-11429: Don't error on existing but now blocked links MBS-11432: Allow also linking places and works to Operabase MBS-11454: Don't consider hasTooEarlyFormat a blocking error MBS-11485: Allow irc(s):// links on expand2react MBS-11503: Block smart links: trac.co MBS-11508: Move Qobuz favicon to external-favicons MBS-11506 - Redirect 'data' link on home page Use EntityLink for link_type links instead of hand-building MBS-9310: Link to relationship type in Add Relationship Type edits MBS-10726 (II): Also do disc -> medium in backend MBS-1178: Relationships table paging Move DIRECTION_ constants to Constants.pm Don't sort arbitrary link types by child_order Improve wording for DisambiguationSameName Make reports use ReportLayout (XII: Releases III) Make reports use ReportLayout (XI: Releases II) Make reports use ReportLayout (X: Releases I) Make reports use ReportLayout (IX: RGs) Make reports use ReportLayout (VIII: Labels / Editors / Events / Places) Make reports use ReportLayout (VII: Recordings) Make reports use ReportLayout (VI: Instruments/ISRCs/ISWCs) Make reports use ReportLayout (V: Discogs links) Make reports use ReportLayout (IV: Artists) Make reports use ReportLayout (III: Duplicate rels) Make reports use ReportLayout (II: Deprecated rels) Make reports use ReportLayout (I: Annotation) Add reusable ReportLayout component MBS-10726: Use "medium", not "disc", as a generic term in RE buttons Bump Flow to 0.147.0 MBS-11217: Only show instrument reports to relationship editors Refactor ReportsIndex to reuse component for each entry MBS-11452: Fix public_subscriptions check in serialize_user MBS-11462: Hide private subscriptions/tags/ratings tabs from admins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always expecting an ID, but edit previews don't yet have an edit ID. Since having separate types for edits and previews would probably be too complicated (many places use ...EditT and whatnot) we just make id possibly null and ensure we specify it is being passed where we use it and know for sure we are passing it.
Warning:
[warning] POST https://musicbrainz.org/ws/js/edit/preview caused a warning: Use of uninitialized value in addition (+) at lib/MusicBrainz/Server/Edit.pm line 330, <$fh> line 1.