Fix partially renamed variable #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
approved these changes
May 15, 2021
mwiencek
added a commit
that referenced
this pull request
May 17, 2021
* origin/schema-change-2021-q2: Update translations from Transifex Bump DB_SCHEMA_SEQUENCE to 26 Bump Flow to 0.151.0 Fix circular require in JSON::LD::Utils Fix broken direction constant use Flush artist_pending_release*_update in tests upgrade.sh: run slave_only SQL after slave SQL Reorder t/sql/initial.sql to avoid FK violations Add missing triggers/tests from #2082 Fix partially renamed variable (#2103) Add dbdefs_to_js helper script to workaround consul-template issue Add Data::Medium::load_track_durations in place of view join Add missing log line Amend b9ff252: Bump to libicu66 for all images Update POT files using the production database Update translations from Transifex Bump SIR_COMMIT to 908e776 Convert *LastUpdatedTriggers scripts to SQL Move -u from shebang to script MBS-11652 (V): Add artist series to JSON schema MBS-11652 (IV): Run `admin/GenerateSQLScripts.pl` MBS-11652 (III): Run `admin/CompileSchemaScripts.pl 26` MBS-11652 (II): Add update scripts to schema 26 MBS-11652 (I): Add SQL support for artist series CheckSchemaMigration.sh: insert initial data before upgrade Speed up listing artist releases/release groups Add slave-only triggers for *_first_release_date tables Add a script to build materialized tables Mark the *_first_release_date update functions as STRICT Add helper functions for the *_first_release_date tables Better handle inline table comments in GenerateSQLScripts.pl MBS-10208 (III): Add a warning when merging different privacy levels MBS-10208 (II): Allow merging collections (Implementation) MBS-10208 (I): Allow merging collections (SQL) Add missing MBS-11451 FKs to upgrade script Add missing comment to upgrade script Add a script to test schema change upgrade scripts Configurable upgrade.sh environment Replace #!/bin/bash with #!/usr/bin/env bash Drop the *_first_release_date tables before creating them Remove trailing whitespace in Entity::Artwork CREATE INDEX IF NOT EXISTS CONCURRENTLY can't be used in a transaction block Handle existing PKCE schema Remove redundant search_path settings from schema 26 scripts MBS-11349: Make medium length consistent MBS-11268: Show "Set track durations" on release/discids MBS-11463: Add view to store medium track durations MBS-11641: Drop redundant rating_raw_idx entity indices (#2091) Remove full-icu Require Perl v5.30, Node v16 Remove unused test dep HTML::HTML5::Sanity Bump MB_SOLR_TAG to v3.4.1 Bump SIR_COMMIT Bump SIR_COMMIT MBS-11451 (II): Support ratings for places - Implementation MBS-11451 (I): Support ratings for places - SQL MBS-11453: Change entity0_cardinality, entity1_cardinality to SMALLINT (#2004) MBS-11466: Change language.frequency and script.frequency to SMALLINT (#2003) MBS-10647: Add [no label] to b_del_label_special trigger (#2001) MBS-11464: Drop table statistics.log_statistic (#2002) MBS-11459: Create edit_data_type_info function on mirrors (#2039) Remove commented out import Remove checks for schema sequence 26 Run ./admin/CompileSchemaScripts.pl 26 Bump NEW_SCHEMA_SEQUENCE to 26 in upgrade.sh
mwiencek
added a commit
that referenced
this pull request
May 17, 2021
* master: Update translations from Transifex Bump DB_SCHEMA_SEQUENCE to 26 Bump Flow to 0.151.0 Fix circular require in JSON::LD::Utils Fix broken direction constant use Flush artist_pending_release*_update in tests upgrade.sh: run slave_only SQL after slave SQL Reorder t/sql/initial.sql to avoid FK violations Add missing triggers/tests from #2082 Fix partially renamed variable (#2103) Add dbdefs_to_js helper script to workaround consul-template issue Add Data::Medium::load_track_durations in place of view join Add missing log line Amend b9ff252: Bump to libicu66 for all images Update POT files using the production database Update translations from Transifex Bump SIR_COMMIT to 908e776 Convert *LastUpdatedTriggers scripts to SQL Move -u from shebang to script MBS-11652 (V): Add artist series to JSON schema MBS-11652 (IV): Run `admin/GenerateSQLScripts.pl` MBS-11652 (III): Run `admin/CompileSchemaScripts.pl 26` MBS-11652 (II): Add update scripts to schema 26 MBS-11652 (I): Add SQL support for artist series CheckSchemaMigration.sh: insert initial data before upgrade Speed up listing artist releases/release groups Add slave-only triggers for *_first_release_date tables Add a script to build materialized tables Mark the *_first_release_date update functions as STRICT Add helper functions for the *_first_release_date tables Better handle inline table comments in GenerateSQLScripts.pl MBS-10208 (III): Add a warning when merging different privacy levels MBS-10208 (II): Allow merging collections (Implementation) MBS-10208 (I): Allow merging collections (SQL) Add missing MBS-11451 FKs to upgrade script Add missing comment to upgrade script Add a script to test schema change upgrade scripts Configurable upgrade.sh environment Replace #!/bin/bash with #!/usr/bin/env bash Drop the *_first_release_date tables before creating them Remove trailing whitespace in Entity::Artwork Allow overriding REPLICATION_TYPE in admin/InitDb.pl CREATE INDEX IF NOT EXISTS CONCURRENTLY can't be used in a transaction block Handle existing PKCE schema Remove redundant search_path settings from schema 26 scripts MBS-11349: Make medium length consistent MBS-11268: Show "Set track durations" on release/discids MBS-11463: Add view to store medium track durations MBS-11641: Drop redundant rating_raw_idx entity indices (#2091) Remove full-icu Require Perl v5.30, Node v16 Remove unused test dep HTML::HTML5::Sanity Bump MB_SOLR_TAG to v3.4.1 Bump SIR_COMMIT Bump SIR_COMMIT MBS-11451 (II): Support ratings for places - Implementation MBS-11451 (I): Support ratings for places - SQL MBS-11453: Change entity0_cardinality, entity1_cardinality to SMALLINT (#2004) MBS-11466: Change language.frequency and script.frequency to SMALLINT (#2003) MBS-10647: Add [no label] to b_del_label_special trigger (#2001) MBS-11464: Drop table statistics.log_statistic (#2002) MBS-11459: Create edit_data_type_info function on mirrors (#2039) Remove commented out import Remove checks for schema sequence 26 Run ./admin/CompileSchemaScripts.pl 26 Bump NEW_SCHEMA_SEQUENCE to 26 in upgrade.sh
mwiencek
added a commit
that referenced
this pull request
May 17, 2021
* beta: Update translations from Transifex Bump DB_SCHEMA_SEQUENCE to 26 Bump Flow to 0.151.0 Fix circular require in JSON::LD::Utils Fix broken direction constant use Flush artist_pending_release*_update in tests upgrade.sh: run slave_only SQL after slave SQL Reorder t/sql/initial.sql to avoid FK violations Add missing triggers/tests from #2082 Fix partially renamed variable (#2103) Add dbdefs_to_js helper script to workaround consul-template issue Add Data::Medium::load_track_durations in place of view join Add missing log line Amend b9ff252: Bump to libicu66 for all images Update POT files using the production database Update translations from Transifex Bump SIR_COMMIT to 908e776 Convert *LastUpdatedTriggers scripts to SQL Move -u from shebang to script MBS-11652 (V): Add artist series to JSON schema MBS-11652 (IV): Run `admin/GenerateSQLScripts.pl` MBS-11652 (III): Run `admin/CompileSchemaScripts.pl 26` MBS-11652 (II): Add update scripts to schema 26 MBS-11652 (I): Add SQL support for artist series CheckSchemaMigration.sh: insert initial data before upgrade Speed up listing artist releases/release groups Add slave-only triggers for *_first_release_date tables Add a script to build materialized tables Mark the *_first_release_date update functions as STRICT Add helper functions for the *_first_release_date tables Better handle inline table comments in GenerateSQLScripts.pl MBS-10208 (III): Add a warning when merging different privacy levels MBS-10208 (II): Allow merging collections (Implementation) MBS-10208 (I): Allow merging collections (SQL) Add missing MBS-11451 FKs to upgrade script Add missing comment to upgrade script Add a script to test schema change upgrade scripts Configurable upgrade.sh environment Replace #!/bin/bash with #!/usr/bin/env bash Drop the *_first_release_date tables before creating them Remove trailing whitespace in Entity::Artwork CREATE INDEX IF NOT EXISTS CONCURRENTLY can't be used in a transaction block Handle existing PKCE schema Remove redundant search_path settings from schema 26 scripts MBS-11349: Make medium length consistent MBS-11268: Show "Set track durations" on release/discids MBS-11463: Add view to store medium track durations MBS-11641: Drop redundant rating_raw_idx entity indices (#2091) Remove full-icu Require Perl v5.30, Node v16 Remove unused test dep HTML::HTML5::Sanity Bump MB_SOLR_TAG to v3.4.1 Bump SIR_COMMIT Bump SIR_COMMIT MBS-11451 (II): Support ratings for places - Implementation MBS-11451 (I): Support ratings for places - SQL MBS-11453: Change entity0_cardinality, entity1_cardinality to SMALLINT (#2004) MBS-11466: Change language.frequency and script.frequency to SMALLINT (#2003) MBS-10647: Add [no label] to b_del_label_special trigger (#2001) MBS-11464: Drop table statistics.log_statistic (#2002) MBS-11459: Create edit_data_type_info function on mirrors (#2039) Remove commented out import Remove checks for schema sequence 26 Run ./admin/CompileSchemaScripts.pl 26 Bump NEW_SCHEMA_SEQUENCE to 26 in upgrade.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whoops, my bad. I only renamed this on the Perl side, so unsurprisingly it does nothing. Found on test.mb.