MBS-11711: Show informative error if no relationships in group #2143
+30
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
reviewed
Jun 11, 2021
Sometimes a link to a specific relationship type group page might become outdated, if all relationships have been moved away from it. Right now, we just detach 400, which seems unfair - the request is not bad, there's just nothing to show. This also adds a relevant message if the link type id given *is* actually invalid (in-page though).
mwiencek
added a commit
that referenced
this pull request
Jul 11, 2021
* master: Fix syntax error Update POT files using the production database Update translations from Transifex MBS-11679: Wish editors a happy MB anniversary (#2116) MBS-10367: Allow requesting copy of sent report when reporting (#1965) MBS-11747: Hide release details on edit preview (#2158) MBS-8371: Add searching in edit notes to the edit search (#1820) MBS-11443: Add option to sort edits by edit note date (#1980) MBS-11578: Link tracks in RecordingTrackDifferentName report (#2097) MBS-11711: Show informative error if no relationships in group (#2143) MBS-11782: Hide more irrelevant work rels from release's bottom credits (#2169) MBS-11335: Report for reused Wikidata items (#1871) MBS-11774: Add fullwidth ｆｅａｔ / ｆｅａｔｕｒｉｎｇ to the featuring reports MBS-11772: Add Greek version to featured artist reports MBS-10844: Report for same URL linked to many entities MBS-11335: Report for reused Wikidata items MBS-11757: CD Japan -> CDJapan (#2157) MBS-11776: Readd "loading-message" class to the medium loading message (#2166) MBS-11767: Show track-level artists on loaded mediums (#2168) MBS-11778: Convert edit header to React (#2167) MBS-11773: Make "featuring in title" reports case insensitive (#2163) Bump Flow to 0.155.0 Bump Flow to 0.154.0 Replace last remaining `__proto__: empty` hack Return a Map from groupBy/keyBy Upgrade Flow to 0.153.0 Rename toJS argument to entity MBS-11775: Do not break if relatedArtists is undefined MBS-11765: Add standalone recording statistics Corrected plural MBS-11769: Display # of recordings w ISRCs / works w ISWCs Fix sort MBS-11761: Properly display ratings on release lists MBS-11753: Fix selectors for RangeSelect in ArtistEdit (#2155) MBS-11744: Make it easier to mouse-select release dates in tables (#2154) MBS-11726: Add missing space to Set Cover Art display (#2153) Fix warning about \1 being better written as $1 Merge pull request #2150 from mwiencek/log-bad-caa-item-uploaders MBS-11381: Add forms for admins to add and update timeline events Deflate field values in Form::Role::ToJSON Correct track_count for INSERT INTO medium MBS-11614: Allow merging releases when a medium is empty MBS-11666: Report for releases that have disc IDs but shouldn't MBS-11664: Enable discID tabs when release (wrongly) has discIDs
reosarevok
added a commit
that referenced
this pull request
Jul 19, 2021
* beta: Add missing space Update POT files using the production database Update translations from Transifex MBS-11781: Add class to the "load all tracks" link on large mediums (#2172) Fix alignment of loading icon for media (#2171) Fix syntax error Update POT files using the production database Update translations from Transifex MBS-11679: Wish editors a happy MB anniversary (#2116) MBS-10367: Allow requesting copy of sent report when reporting (#1965) MBS-11747: Hide release details on edit preview (#2158) MBS-8371: Add searching in edit notes to the edit search (#1820) MBS-11443: Add option to sort edits by edit note date (#1980) MBS-11578: Link tracks in RecordingTrackDifferentName report (#2097) MBS-11711: Show informative error if no relationships in group (#2143) MBS-11782: Hide more irrelevant work rels from release's bottom credits (#2169) MBS-11335: Report for reused Wikidata items (#1871) MBS-11774: Add fullwidth ｆｅａｔ / ｆｅａｔｕｒｉｎｇ to the featuring reports MBS-11772: Add Greek version to featured artist reports MBS-10844: Report for same URL linked to many entities MBS-11335: Report for reused Wikidata items MBS-11757: CD Japan -> CDJapan (#2157) MBS-11776: Readd "loading-message" class to the medium loading message (#2166) MBS-11767: Show track-level artists on loaded mediums (#2168) MBS-11778: Convert edit header to React (#2167) MBS-11773: Make "featuring in title" reports case insensitive (#2163) Bump Flow to 0.155.0 Bump Flow to 0.154.0 Replace last remaining `__proto__: empty` hack Return a Map from groupBy/keyBy Upgrade Flow to 0.153.0 Rename toJS argument to entity MBS-11775: Do not break if relatedArtists is undefined MBS-11765: Add standalone recording statistics Corrected plural MBS-11769: Display # of recordings w ISRCs / works w ISWCs Fix sort MBS-11761: Properly display ratings on release lists MBS-11753: Fix selectors for RangeSelect in ArtistEdit (#2155) MBS-11744: Make it easier to mouse-select release dates in tables (#2154) MBS-11726: Add missing space to Set Cover Art display (#2153) Fix warning about \1 being better written as $1 MBS-11381: Add forms for admins to add and update timeline events Deflate field values in Form::Role::ToJSON Correct track_count for INSERT INTO medium MBS-11614: Allow merging releases when a medium is empty MBS-11666: Report for releases that have disc IDs but shouldn't MBS-11664: Enable discID tabs when release (wrongly) has discIDs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-11711
Sometimes a link to a specific relationship type group page might become outdated, if all relationships have been moved away from it. Right now, we just detach 400, which seems unfair - the request is not bad, there's just nothing to show.