MBS-11799: Display "credited as" field in sidebar external links #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
reviewed
Jul 26, 2021
It makes sense to specify the credits for URL rels on the sidebar.
On one hand, it helps find them to fix them when they are
unwanted results from a merge. On the other hand, it shows
the differences between, say, several Discogs pages for the same
MB artist under different aliases.
Making the whole thing one exp.l because having {url} as {credit}
seems a lot easier to translate.
reosarevok
force-pushed
the
MBS-11799
branch
from
e5eecc3
to
4c37b02
Compare
mwiencek
approved these changes
Sep 7, 2021
|
@brainzbot, retest this please |
yvanzo
approved these changes
Sep 9, 2021
Comment on lines
+58
to
+59
| element = exp.l( | ||
| '{url} (as {credited_name})', |
There was a problem hiding this comment.
Side note: As a translator I would probably not be able to understand what it means without digging the code. But adding a comment like “For linked URL crediting an entity with a different name.” would require MBS-10864. Can be added later on without breaking existing localizations.
mwiencek
added a commit
that referenced
this pull request
Sep 13, 2021
* master: Update POT files using the production database Replace "special entity" with "special purpose entity" Update translations from Transifex MBS-11130: Clarify it's not possible to subscribe to VA / [no label] (#1754) MBS-11841: Convert Set Track Lengths edit to React (#2234) MBS-11819: Show to admins whether account has oAuth uses (#2250) MBS-8820: Show explanation if artist relationships tab shows no rels (#1977) MBS-8098: Allow release-group-level-rels in release lookup (#2213) MBS-6140: Allow (recording|work)-level-rels for release browse (#2173) MBS-11940: Properly error for invalid XML sent to /ws/2/tag (#2258) MBS-11843: Add report for "Events with annotations" (#2193) Make user/tag pages 403 if tag is meant to be private Add test for RemoveEmpty url Make the timeline icon clearer & easier to click MBS-11794: Link to edit searches on statistics/edits page MBS-11799: Display "credited as" field in sidebar external links (#2180) Ensure tooltip content has standard formatting MBS-11717: Also show edits pending in ArtistCreditUsageLink MBS-11944: Fix label on button for place merges (#2254) MBS-11907: Block vyd.co link aggregator (#2249) In-code doc: Comment URL rel. UUIDs with name Bump Flow to 0.159.0 MBS-11932: Also exclude work licenses from LinksWithMultipleEntities Set hostname of MB data export MBS-9454: Autoremove unused urls with daily.sh
reosarevok
added a commit
that referenced
this pull request
Sep 20, 2021
* beta: Update POT files using the production database Update translations from Transifex Update POT files using the production database Replace "special entity" with "special purpose entity" Update translations from Transifex MBS-11130: Clarify it's not possible to subscribe to VA / [no label] (#1754) MBS-11841: Convert Set Track Lengths edit to React (#2234) MBS-11819: Show to admins whether account has oAuth uses (#2250) MBS-8820: Show explanation if artist relationships tab shows no rels (#1977) MBS-8098: Allow release-group-level-rels in release lookup (#2213) MBS-6140: Allow (recording|work)-level-rels for release browse (#2173) MBS-11940: Properly error for invalid XML sent to /ws/2/tag (#2258) MBS-11843: Add report for "Events with annotations" (#2193) Make user/tag pages 403 if tag is meant to be private Add test for RemoveEmpty url Make the timeline icon clearer & easier to click MBS-11794: Link to edit searches on statistics/edits page MBS-11799: Display "credited as" field in sidebar external links (#2180) Ensure tooltip content has standard formatting MBS-11717: Also show edits pending in ArtistCreditUsageLink MBS-11944: Fix label on button for place merges (#2254) MBS-11907: Block vyd.co link aggregator (#2249) In-code doc: Comment URL rel. UUIDs with name Bump Flow to 0.159.0 MBS-11932: Also exclude work licenses from LinksWithMultipleEntities Set hostname of MB data export MBS-9454: Autoremove unused urls with daily.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-11799
It makes sense to specify the credits for URL rels on the sidebar. On one hand, it helps find them to fix them when they are unwanted results from a merge. On the other hand, it shows the differences between, say, several Discogs pages for the same MB artist under different aliases.
For now, these credits can only be added when editing a URL or automatically through a merge, but I expect @y-young's work on better editing for URLs on the entity pages will make credits more available elsewhere too :)