Autocomplete2 editor fixes #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was using ENTITIES.url for calling ws/js, but the url for editor is "user". That is correct for the website, but in ws/js, the actual url is "editor". Also, determineIfUserCanAddEntities needs to reject editors, since obviously we don't support creating new editors from a search.
None of these three currently support adding new entities from a search. We're also unlikely to search them in situations where we would support adding new entities, but it seems sensible to block them preemptively.
mwiencek
reviewed
Aug 2, 2021
Comment on lines
+81
to
+83
| const entityWebServicePath = state.entityType === 'editor' | ||
| ? 'editor' | ||
| : ENTITIES[state.entityType].url; |
There was a problem hiding this comment.
Heh, that's annoying. Maybe we should alias it to ws/js/user at some point.
I know that, but since it's relatively minor, it might not be worth fixing if it no longer happens with Autocomplete2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues I found while I was trying to figure out if MBS-11588 was an issue in Autocomplete2. Which I'm still not sure about, but that's a different question (@mwiencek, do you know the answer?).