MBS-11824 / MBS-11833: Featured reports regex improvements #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost all cases I can see are false positives: stuff like "(F. Chopin), or just "F. Whatever remix". It seems to be pretty uncommon for f. X to actually be used as feat, so while it could make sense to support it on the guess feat button (where it would be used mostly if the user already knows there's featured artists on a tracklist or title), the false positives make it unwise to have it on the reports. For what it's worth, we don't seem to even use this in featRegex for the button either.
This still requires a space after full words (featuring, duet with) but not after feat. and other abbreviations, to help find and fix the not too uncommon cases where the original editor missed the space.
|
@brainzbot, retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-11824 / MBS-11833
See commit messages. Tested by running the reports locally and comparing them.