Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-11941: Normalize Worldcat identities URLs #2257

Merged
merged 1 commit into from Sep 27, 2021

Conversation

reosarevok
Copy link
Member

@reosarevok reosarevok commented Sep 8, 2021

Implement MBS-11941

This ensures the permalinks to Worldcat identities pages include the ending slash, since that's their default.
Additionally, wcidentities pages get converted into identities pages (as far as I can tell they are both the same content with a slightly different design).

@reosarevok reosarevok added the QoL Non-urgent quality of life improvements label Sep 8, 2021
@reosarevok reosarevok added this to the 2021-10-04 milestone Sep 13, 2021
Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last commit looks good to me but needs to be rebased on master after merging the pull request it depends on.

This ensures the permalinks to Worldcat identities pages
include the ending slash, since that's their default.
Additionally, wcidentities pages get converted into identities pages
(as far as I can tell they are both the same content with a slightly
different design).
@reosarevok reosarevok merged commit d0ba327 into metabrainz:master Sep 27, 2021
@reosarevok reosarevok deleted the MBS-11941 branch September 27, 2021 17:25
reosarevok added a commit that referenced this pull request Sep 28, 2021
* master:
  Update POT files using the production database
  Update translations from Transifex
  MBS-11998: Also include places on rating stats sum (#2291)
  MBS-11952: Autoselect Vimeo On Demand URLs correctly (#2262)
  MBS-11830: Add more collection statistics (#2198)
  Remove unneeded non-capturing groups
  MBS-11975: Clean up CDJapan detailview URLs
  MBS-10621 (2/2): Normalize and validate Tidal URLs
  Fix URL module alphabetical sort (again)
  MBS-10621 (1/2): Display Tidal URLs in the sidebar
  MBS-11959: Allow RYM links for music video recordings (#2261)
  MBS-11957: Clean up twitch.com to twitch.tv (#2260)
  MBS-11941: Normalize Worldcat identities URLs (#2257)
  MBS-11968: Allow LoC links for series
  MBS-11968: Allow DNB links for series
  MBS-11968: Autoselect and restrict VIAF for series
  MBS-11989: Also correct rg to release_group for delete_alias (#2286)
  Coding style: Restore multi-line strings indent
  MBS-11977 Fix targeting ENTITY for URL rel error
  Add URL error messages for mismatched entity types
  MBS-11973: Also load edits_pending for appears_on (#2278)
  MBS-11896: Remove the unique_primary_for_locale triggers and functions (#2266)
  Bump Flow to 0.160.2
reosarevok added a commit that referenced this pull request Oct 4, 2021
* beta:
  Update POT files using the production database
  Update translations from Transifex
  MBS-12000: Fix error msg for incompatible entity (#2295)
  Update POT files using the production database
  Update translations from Transifex
  MBS-11998: Also include places on rating stats sum (#2291)
  MBS-11952: Autoselect Vimeo On Demand URLs correctly (#2262)
  MBS-11830: Add more collection statistics (#2198)
  Remove unneeded non-capturing groups
  MBS-11975: Clean up CDJapan detailview URLs
  MBS-10621 (2/2): Normalize and validate Tidal URLs
  Fix URL module alphabetical sort (again)
  MBS-10621 (1/2): Display Tidal URLs in the sidebar
  MBS-11959: Allow RYM links for music video recordings (#2261)
  MBS-11957: Clean up twitch.com to twitch.tv (#2260)
  MBS-11941: Normalize Worldcat identities URLs (#2257)
  MBS-11968: Allow LoC links for series
  MBS-11968: Allow DNB links for series
  MBS-11968: Autoselect and restrict VIAF for series
  MBS-11989: Also correct rg to release_group for delete_alias (#2286)
  Coding style: Restore multi-line strings indent
  MBS-11977 Fix targeting ENTITY for URL rel error
  Add URL error messages for mismatched entity types
  MBS-11973: Also load edits_pending for appears_on (#2278)
  MBS-11896: Remove the unique_primary_for_locale triggers and functions (#2266)
  Bump Flow to 0.160.2
  Also use localizeLanguageName for entity sidebars
  Update POT files using the production database
  Update translations from Transifex
  MBS-10902: Stop changing zxx language name at the Perl level (#2255)
  MBS-11961: Rename "random" in edit search since it's not random (#2264)
  MBS-11970: Add recaptcha.net to script-src CSP (#2271)
  MBS-11852: Only call TO_JSON on editor if it exists (#2246)
  Change EOSQL to SQL for TextMate/VSCode
  Re-enable running Perl::Critic now that errors are fixed
  Remove useless .js extensions in component_path
  Fix Perl::Critic useless interpolation and endspace in remaining files
  Fix Perl::Critic useless interpolation and endspace in Controller:: files
  Fix Perl::Critic useless interpolation and endspace in Form:: files
  Fix Perl::Critic useless interpolation in EditSearch:: files
  Fix Perl::Critic useless interpolation and endspace in Edit:: files
  Fix Perl::Critic useless interpolation and endspace in Report:: files
  Fix Perl::Critic useless interpolation in Script:: files
  Fix Perl::Critic useless interpolation in Sitemap:: files
  Fix Perl::Critic useless interpolation in WebService:: files
  Fix Perl::Critic useless interpolation in Entity:: files
  Fix Perl::Critic useless interpolation and endspace in Data:: files
  Fix Perl::Critic useless interpolation in Data::Role files
  Fix Perl::Critic useless interpolation in Data::Statistics
  MBS-11978: Move link action icons to the left (#2273)
  Add seeded links after any existing ones
  MBS-11960: Also assign seeded URL to rawURL
  Log copying JSON dump and search index dump to FTP
  Allow limiting compression threads from config
  Fix wrongly named "args" variable
  MBS-10639: Convert release merge edit to React
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QoL Non-urgent quality of life improvements
Projects
None yet
3 participants