Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MB Homepage Revamp #2310

Closed
wants to merge 42 commits into from
Closed

MB Homepage Revamp #2310

wants to merge 42 commits into from

Conversation

akshaaatt
Copy link
Member

@akshaaatt akshaaatt commented Oct 20, 2021 •
edited

This implements a modern look to the MusicBrainz Web Homepage.

Discussion available at: https://community.metabrainz.org/t/musicbrainz-web-homepage-2021/554362

@akshaaatt akshaaatt self-assigned this Oct 20, 2021
@akshaaatt akshaaatt marked this pull request as draft October 20, 2021 22:35
mwiencek
mwiencek reviewed Oct 21, 2021
View reviewed changes
Copy link
Member

@mwiencek mwiencek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the actual code at all, but just wanted to leave some initial comments about how the project is set up.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
root/main/components/Home/About/About.js Outdated Show resolved Hide resolved
root/main/components/Home/About/About.js Outdated Show resolved Hide resolved
akshaaatt and others added 17 commits October 25, 2021 07:16
@akshaaatt
Cleanup done and corrections made
6073ed3
@akshaaatt
Subtle changes
45d5d08
@akshaaatt
styles corrected
2fcf5fa
@akshaaatt
Configurations working now
8acd944
@akshaaatt
Merge branch 'master' into akshat/homepage-revamp
73e2dbd
@akshaaatt
Necessary updates made
a98d52c
@akshaaatt
Merge branch 'akshat/homepage-revamp' of https://github.com/metabrain…
52eeca5 
…z/musicbrainz-server into akshat/homepage-revamp
@akshaaatt
License header added
2f4983b
@akshaaatt
Merge branch 'master' of https://github.com/metabrainz/musicbrainz-se…
89a44bc 
…rver into akshat/homepage-revamp
@akshaaatt
Merge branch 'master' of https://github.com/metabrainz/musicbrainz-se…
6704133 
…rver into akshat/homepage-revamp
@akshaaatt
Merge branch 'master' of https://github.com/metabrainz/musicbrainz-se…
ebef2f9 
…rver into akshat/homepage-revamp
@akshaaatt
Updates made
6ac08c6
@akshaaatt
Lint fixes
a65c715
@akshaaatt
Major updates made
bf292d4
@akshaaatt
- Eslint issues fixed
0ab07ba 
- Shared components corrected
@akshaaatt
Eslint issues fixed
b857aa5
@akshaaatt
Corrected BarcodeScanner.tsx , ScrollToTop.js, ThemeSwitchButton.js a…
b7fdd32 
…nd fixed eslint issues
@akshaaatt akshaaatt marked this pull request as ready for review December 13, 2021 08:20
@mwiencek
Copy link
Member

Hi @akshaaatt, we took a look at this PR as a team, but it's way too big and unwieldy as it is, so we'd like to have a meeting with you where we spend a couple hours picking a section of it and integrating that into the current homepage.
There are some code issues here that require mentorship, so it'll be much more manageable if we can break this into smaller chunks and work together on smaller PRs. But we'll have to determine the best way to do that without making the homepage schizophrenic. I'll ping you on IRC about setting up a meeting. :)

@akshaaatt
Copy link
Member Author

Smaller PRs are being worked on to update the Homepage :)

@akshaaatt akshaaatt closed this Mar 10, 2022
@akshaaatt akshaaatt deleted the akshat/homepage-revamp branch March 10, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwiencek mwiencek mwiencek left review comments

Assignees

@akshaaatt akshaaatt

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@akshaaatt @mwiencek