Avoid using multiple with in Data:: files #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
force-pushed
the
no-multiple-with-data
branch
from
b9b7023
to
c88e3e2
Compare
This was referenced Nov 25, 2022
Role::OptionsTree already applies Role::SelectAll, so trying to apply it again causes Moose issues (these are currently hidden because we incorrectly use multiple with). Since we want to be able to pass an order_by parameter to SelectAll, I made OptionsTree parameterizable and made it pass the parameter through.
reosarevok
force-pushed
the
no-multiple-with-data
branch
from
c88e3e2
to
b4932ad
Compare
mwiencek
reviewed
Dec 4, 2023
https://metacpan.org/pod/Perl::Critic::Policy::Moose::ProhibitMultipleWiths Since this involves a lot of files, doing it in parts to ensure it's easier to find what broke if something does - this just for Data::
reosarevok
force-pushed
the
no-multiple-with-data
branch
from
b4932ad
to
7cfbd49
Compare
mwiencek
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://metacpan.org/pod/Perl::Critic::Policy::Moose::ProhibitMultipleWiths
Since this involves a lot of files, doing it in parts to ensure it's easier to find what broke if something does - this just for Data::
On top of #2704
Several files were applying
Role::Areatwice, and there was a clash whenRole::SelectAllwas being applied to files already applyingRole::OptionsTree(which itself appliesRole::SelectAll).