MBS-12780: Fix allowNew check for AddRelationship #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was checking for the entity0 and entity1 passed outside the relationship itself - which we were also adding to the relationship data for display. But we were only passing this if the ID was not defined in the first place, so this check was nonsensical AFAICT. In fact, I cannot find any reason to pass entity0 and entity1 outside the relationship, since we're already passing them inside it. I'm also removing the source_type and target_type that I had added in 9b0eae3 since AFAICT we're again not using those, but the ones inside the relationship object.
|
I tested it against older edits with removed entities and edit previews in the release editor, and it seems to work as expected. |
mwiencek
approved these changes
Dec 11, 2022
mwiencek
added a commit
that referenced
this pull request
Jan 6, 2023
* master: Make autocomplete action items use italics MBS-12784: Mark more tracklist errors as such (#2783) MBS-12205: Add "play on ListenBrainz" button MBS-12780: Fix allowNew check for AddRelationship (#2770) MBS-12778: Don't block area removal based on open edits (#2765) MBS-12630: Make the relationship type autocompletes more compact Drop template converted to React since 0dc0763 Drop template converted to React since fd51e30
yvanzo
added a commit
that referenced
this pull request
Feb 28, 2023
* beta: Update translations from Transifex Update POT files using the production database Convert 0 linkTypeIDs to null for the relationship dialog (#2868) EntityLink: replace captureMessage with captureException Template renderer: set component, url tags for Sentry Unset the Sentry user in the template renderer Update POT files using source code only MBS-12931: Hide (+) button if no relationship type Merge help toggle links in relationship editor Copy runit logs to musicbrainz-server checkout MBS-12935: Link to relationship type tree docs MBS-12935: Readd relationship type help in editor MBS-12937: Changing credits should work without modifying the source relationship (#2865) MBS-12936: Don't update Autocomplete2 scroll position on item mouseover (#2864) Update translations from Transifex Update POT files using the production database Server::Entity: Consistently serialize `id` as a number Autocomplete2: Rework showAvailableItems Disable CSP headers for Selenium requests Set MUSICBRAINZ_RUNNING_TESTS in Selenium tests Fix Webpack warning about DEVELOPMENT_SERVER import Autocomplete2: Clicking search icon should focus the input Autocomplete2: Add effect cleanup handlers MBS-12924: Fix page freeze after selecting a link type on Android Allow configuring Webpack devtool via the environment MBS-12918: Reset credit string when updating target type (#2860) Log browser console after each Selenium test (#2861) Throw error if nameVariation is not set as needed MBS-12917: Fix title of credited entity’s link Update POT files using source code only Update translations from Transifex MBS-12911: Can't link two new works together Allow spaces after NEW_WORK_HASH MBS-12919: Show warning icon when rel has pending edits (#2858) MBS-12930: Validate relationship fields on Perl level (#2854) MBS-12923: Stop submission when no changes made (#2855) MBS-12925: Allow submitting work dialogs with Enter (#2856) MBS-12932: Always show [No lyrics] in work languages (#2857) MBS-12928: Sort related works by name before ID Make the Data::Artist::find_by_instrument order deterministic MBS-12922: Autocomplete2: allow triggering a search with space MBS-12921: Can't search for works in the "Add related work" dialog MBS-12915: Default to 'artist' in the add-relationship dialog (#2849) MBS-12926: Remove indents from Autocomplete search results MBS-12806: Do not show "Play on LB" button for empty releases (#2801) MBS-12816: Highlight doc header when linking to fragment (#2794) MBS-11770: Load work languages for recently used works (#2848) Update translations from Transifex Update POT files using the production database MBS-12908: Do not reuse "cancelled"/"time" for artist-event rels (#2846) MBS-12896: Show admins whether user is banned from profile (#2845) MBS-11529: "Guess feat. artists" removes primary artist Factor out relatedArtists and isProbablyClassical utilities MBS-12903: Fix "Guess feat. artists" button exception Relationship editor required field style redux (#2830) MBS-12665: Widen DNB regex (#2686) MBS-12853: Disallow IPI that is all zeros (#2833) MBS-12814: Remove animationsong.com from the lyrics whitelist (#2791) MBS-12899: Add TMDB to the otherdbs whitelist for artists (#2838) MBS-12829: Use link type phrases in autocomplete input value (#2840) MBS-12641: Relationship dialog initial focus improvements Autocomplete2: Wait for recent items before showing menu MBS-12882: Adding & removing a relationship date shows pending edits (#2831) Clarify what to do for batch operations on tracks MBS-11770: Always list related entities for events MBS-11770: Always list events/labels for releases MBS-12904: Fix another error submitting a recording artist relationship Catch prepareHtmlFormSubmission errors MBS-12875: Disable selecting incomplete mediums Fix selecting mediums with no recordings MBS-12873: Avoid unloaded tracks to change credits MBS-11770: Always list ISRC/RGs for recordings Refactor: Move hasUnloadedTracks to a function MBS-11770: Always list related artists for works MBS-12891 / MBS-7971: Show more info for inline artist/label search (#2839) MBS-12890: Show disambiguation in label/genre autocompletes (#2834) MBS-12901: Show user website an bio on the admin user views (#2841) MBS-12870: Trap focus inside the Popover component (#2826) MBS-12863: Tooltips too far to the left (#2819) MBS-12888: Check ended when copying end date Actually look at stringy dates with isDateEmpty Autocomplete2: For "noop" actions, hide the menu instead MBS-12872: Autocomplete2: Don't focus the first item unless searching MBS-12885: Instrument disappears after adding another Sort attributes passed to fromDistinctAscArray MBS-12874: Don't split new relationships with one instrument or vocal MBS-12880: Support fieldset.row legend styling again (#2823) Add a Selenium test for MBS-12859 MBS-12832: Improve edit submission batching in the release relationship editor MBS-12860: Fix "Two relationships with the same key" error Make the error message display consistent in the relationship editors MBS-12861: Improve "Two relationships with the same key" message Always show "change credits" if there's a credit Also show disambiguation if there's an entity credit MBS-12859: Allow credit to be the same as name Update translations from Transifex Update POT files using the production database Migrate tx/.config to the new format Bring back the relationship dates help text Increase relationship icon spacing (and size on touch devices) Revert "Autocomplete2: Don't update menu on mouse move" Make the attributes help link less strong Update the yarn GPG key Make overly long link phrase display consistent MBS-12850: Fix visual bug when seeding backwards relationships MBS-12849: Allow seeding relationship entity credits MBS-12834: Suppress relationship type menu on dialog open Add some spacing before the copy-date button Replace "required field" error message with red background Change the link type autocomplete placeholder Autocomplete2: Mimic jQuery UI Autocomplete style Reduce p margin in relationship dialog Tooltip: use CSS for hovering instead of JavaScript Memoize ButtonPopover Consolidate span.partial-date styling Rename 'Type' to 'Related type' Reduce relationship dialog sub-heading padding MBS-12830: Make the relationship editor UI more compact Right-align the relationship dialog's "Done" button Don't close relationship dialogs when clicking outside of them Clarify disabled batch tool buttons Incorporate improvements suggested by Aerozol in MBS-11847 MBS-12858: Load containment for recent area/place autoselects MBS-12857: Load type for ws/js /entities returns Standardize 1 to true MBS-12837: Add autoselect + sidebar for Tsutaya URLs (#2807) MBS-12831: Don't hide disambiguations in relationship previews (#2805) Update the ways to access $c from JavaScript (#2806) MBS-12721: Normalize 45cat.com/45worlds.com links to HTTPS (#2748) Document Work::Edit Document URL::Edit Document Series::Edit Document ReleaseGroup::Edit Document Recording::Edit Document and expand Place::Edit Document Label::Edit Standardize already cleaned ::Edit tests Document Work::Create Document Series::Create Document and expand Place::Create Document Label::Create Document and standardize Controller::Details tests Properly test text contents in details tab Document and standardize Controller::AddAnnotation tests Standardize already cleaned ::Create tests Move tests for the place index to Place::Show MBS-12828: Skip removing collection collaborator (#2803) MBS-12693: Select relationship type before target (#2800) Expose linkedEntities to userscripts Make autocomplete action items use italics MBS-12709: Do not copy series part number with "Add another [entity]" (#2798) MBS-12820: Add default label for attribute multiselects (#2799) MBS-12809: Pass minimal existing data for Historic/RemoveDiscID (#2792) MBS-12817: Fix selector for relationship dialog warnings (#2795) MBS-12787: Editing a relationship to add instruments causes duplication (#2797) MBS-12737: Properly check backwardness with isRelationshipBackward (#2796) MBS-12784: Mark more tracklist errors as such (#2783) Update POT files using the production database Update translations from Transifex MBS-12205: Add "play on ListenBrainz" button MBS-12205: Add "play on ListenBrainz" button MBS-12780: Fix allowNew check for AddRelationship (#2770) MBS-12778: Don't block area removal based on open edits (#2765) MBS-12630: Make the relationship type autocompletes more compact Drop template converted to React since 0dc0763 Drop template converted to React since fd51e30 Update POT files using the production database Update translations from Transifex Amend f2446af/#2743: Import missing translation (#2760) MBS-12735 (II): Normalize/validate Boomplay URL MBS-12735 (I): Display Boomplay URL in the sidebar MBS-12685: Avoild ISE because of concurrent rating transactions (#2711) MBS-12716: Output the right JSON-LD @context (#2746) MBS-12722: Add IdRef to the other databases whitelist (#2749) MBS-12445: Handle Audiomack URLs (#2743) MBS-12713: Add KBR to the other databases whitelist (#2744) Update translations from Transifex Update POT files using the production database Validate invalid session ID cookies earlier (#2742) MBS-12695: Fix encoding issue in "Add a new entity" dialog (#2720) MBS-12694: Fix error submitting a recording artist relationship (#2719) Fix some multiselect attribute bugs in the relationship editor (#2718) MBS-12687: Block smart links: allmylinks.com (#2713) Make Flow ignore intentionally broken file Regenerate yarn.lock Removing unused imports MBS-12679: Refresh dialog attributes when entity type changes SEC-123: Upgrade @babel packages to drop kind-of Fix warnings in DAOLogger (#2738) Add another missing Types module import for Genre (#2739) SEC-904: Upgrade babel-loader to drop loader-utils (#2736) Generate SQL scripts for unreferenced_row_log (#2728) Replace span with div since span > div is invalid Avoid warning when seeing empty lines Avoid warning on undefined $opts{$count_prop} Avoid warning about uninitialized relatable Move li under the appropriate ul elements Actually send users to the right page on linktype delete Avoid warning about uninitialized $version Avoid warning about redeclaring $response Avoid warning about redeclaring $alias Avoid warning when new length is null Separate sprintf arguments from test comment Avoid Prototype mismatch warning Avoid warning about uninitialized medium_id Avoid warning when passing undef to normalise_strings Avoid warning when scheme is undef Avoid warning about uninitialized edit note Avoid warning about uninitialized current/new max Also use strict/warnings on tests DBDefs file Avoid warning about redefined comma_list Remove unused sub diag_lineno Get rid of warning to use $1 over \1 Add Critic RequireUseStrict / RequireUseWarnings rules Use our @isa rather than @isa Remove non-existing variable $ignore Don't look at critic.t with critic.t Use my @ALL rather than @ALL Move use Moose out of BEGIN block Add an easy way to set dialog attributes from userscripts Actually look at notes permission in editorMayAddNote MBS-10614: Remove edit note / vote restrictions for beginners MBS-12703: Add genre l_ tables to @CORE_TABLE_LIST (#2721) MBS-12552: Move Entity role Linkable to Relatable (#2717) Follow 6647f3a: Drop Core occurrences from POD SEC-900: Upgrade nodemon to use fixed minimatch (#2716) Load Moose types on files using them (#2710) Make sidebar h3 black MBS-12673: Make it clearer that genres are added as tags Comment on roles sort order Explicitly require '_type' for Data roles Require `_hash_to_row` for `Data::Role::GID` Split and remove Data::CoreEntity empty package Rename Data role CoreEntityCache as GIDEntityCache Document the methods of the role MainTable Refactor: Move main table definition to a role Use safer utility function to read entity model Document the methods of the role EntityModelClass Refactor: Move defining entity class sub to a role Refactor: Move GID data to a separate role Refactor: Move GID redirect data to a role apart Document the methods of the new Data::Role::Name Refactor: Move entity name data to a separate role MBS-12681: Support YouTube Handle (#2709) Update POT files using the production database Update translations from Transifex Don't use no longer existing merge.tt (#2703) Document updating ChromeDriver Bump chromedriver to 106.0.5249.61 Use Perl::Critic::Moose::ProhibitNewMethod reset_selenium_env.sh: prune the cache Add Autocomplete2 test for MBS-12631 Autocomplete2 fixture: rename vocal test MBS-12631: Autocomplete2: Don't show unselectable items Document MODERN_BROWSERS=1 MBS-12672: Add "Genre" to edit search like other entities (#2697) Allow compiling JS for modern browsers in development Refactor: Drop Editable role from Moose Collection Factorize name with role in Moose entity classes Refactor: Remove duplicate name in Moose Track Refactor: Factorize last updated to core in Moose Refactor: Make core entities linkable in Moose Refactor: Remove collection and track from core Refactor: Move entity name to a Moose role Update caniuse-lite Add very basic CD stub search selenium test MBS-12666: Show video attribute in its own line MBS-12666: Strip attributes from phrases in links editor Make Autocomplete2 flow strict (#2678) MBS-12674: Don't assume offset data exists Upgrade Flow to 0.190.0 Upgrade Flow to 0.189.0 Upgrade Flow to 0.188.2 MBS-12668: Support more entity types for Melon MBS-12668: Support more entity types for Bugs! MBS-12668: Add URL cleanup for Melon MBS-12643: Hide non-editable link orders in the relationship editor (#2692) MBS-12667: Add Bugs! and Melon links to sidebar (#2693) MBS-12668: Add URL cleanup for Bugs! Fix warning when starting the server (#2680) MBS-12632 (II): DialogPreview: use [unknown] instead of [removed] MBS-12632 (I): Pass the pre-filled entity name to the relationship editor AddEntityDialog: Pass name via query parameter MBS-12640: Preview always on for instrument relationships (#2689) Add some basic knockout libdefs Make more files flow strict Make editDiff flow strict Mark some more files flow strict Upgrade mutate-cow to v4.1.1 Add a separate empty fn for readability Make all possible files flow strict Make report files flow strict Make tableColumns flow strict Make even more files flow strict Make expand2 flow strict Add flow types for po2json Make EntityLink flow strict-local Make entityHref flow strict Ignore untyped-import of ko for ko.unwrap Make gettext flow strict-local Change flow comments to raw types in mjs files Specify we should run mjs script with sucrase Add flow types to poFile.mjs Disable eqeqeq rule as per comment above line Set more files to flow strict w/o other changes Remove no longer needed ignore Make some common utilities flow strict Make AcousticIdCell flow strict Make CDStubInfo flow strict Eslint fixes for formatTrackLength Make formatTrackLength flow strict Make EntityHeader flow strict-local Make PaginatedResults flow strict Make Paginator flow strict Make Table flow strict Make Head flow strict-local Make AnnotationLinks flow strict-local Make ReleaseGroupIndex flow strict-local Make manifest flow strict Make Annotation flow strict-local Make EditorLink flow strict-local Make Relationships flow strict-local Make StaticRelationshipsDisplay flow strict-local Make expand2react flow strict-local Make expand2text flow strict-local Make wrapGettext flow strict-local Make compareDates flow strict Make FormRowCheckbox flow strict-local Make FormRowSelect flow strict-local Make DiffSide flow strict-local Make linkPhrase.js flow strict-local Make LanguagesScripts flow strict-local Make more files flow strict(-local) Set more strict(-local) now entities.mjs has flow Make constants flow strict Handle versions of Node.js > 16 in bin/sucrase-node (#2677) Disable no-await-in-loop in selenium.mjs Disable deprecation warning when using createStore Bump Redux version to 4.2.0 Fix key orders in xgettext.js Fix let -> const in web.js Fix some eslint issues in selenium.mjs Fix eslint issues in the webpack folder Fix import sort in server.mjs Eslint fixes for components.mjs Update translations from Transifex Update POT files using the production database Help userscripts integrate with the relationship editor, pt. 2 (#2671) MBS-12646: Can't change time on artist-event relationship (#2670) Make GenreEditForm, AliasEditForm strict-local MBS-12645: Add guess case to genre edit form MBS-12648: Add missing UI to sort RG collections by artist MBS-12647: Fix ISE in RG collection artist sort Data::Instrument: Replace get_all method with Data::Role::SelectAll MBS-12629: Adding new instrument doesn't clear type-info cache Data::LinkType: Use Data::Role::SelectAll MBS-12644: Autocomplete2: Strip attributes from link type phrases Reduce some padding/spacing in the relationship dialog Make the instrument/vocal section more compact HelpIcon/Tooltip: Add Flow types, convert to functional components Reduce dialog h1 size slightly Make the relationship credit controls less conspicuous Update countries.pot from the database Update translations from Transifex MBS-12639: Also update countries.pot from the DB MBS-12625: Autocomplete2: Show recent instruments (#2663) Fix relationship seeding test for 1cfb62e Increase Selenium test timeout to 8 minutes MBS-12626: Fix error submitting multiple instrument relationships Release relationship editor: handle submission errors better MBS-12634: Show disambiguation for related entities Update translations from Transifex Update POT files using the production database Fix artist relationship editor test Fix series relationship editor test MBS-12603: Allow removing work relationships from the works column Factor out iterateTargetEntitiesOfType Simplify relationship editor's work-recording association MBS-12550: Don't enter useless annotation edit in merge (#2640) MBS-12623: Editor icon is too large (#2639) MBS-12624: Autocomplete2: Improve static search results (#2660) MBS-12610: Discard selected link type name when changing entity type (#2654) MBS-12615: Fix compactEntityJson for other-document data (#2656) MBS-12605: Autocomplete2: Tab to select items (#2653) MBS-12604: Autocomplete2: Show '[No lyrics]' for work language (#2652) MBS-12620: Autocomplete2: "Show more" missing (#2659) MBS-12619: <Enter> on a button shouldn't accept the relationship dialog (#2658) MBS-12616: Fix crash in relationship dialog searching for release (#2657) MBS-12611: Fix medium table heading alignment (#2655) MBS-12601: Limit batch work creation to where works aren't linked (#2651) MBS-12599: Relationship editor no longer warns of losing changes (#2649) MBS-12612: Default showDisambiguation to false in ArtistCreditLink (#2648) MBS-12597: Set min size for relationship editor works column (#2646) MBS-12595: Set deletedCaption for batch relationship preview (#2645) Hide tracklist disambiguation in release relationship editor MBS-12598: In relationship editor, open track ACs in new tab MBS-12628: Hide phrases for unselectable reltypes in inline search (#2643) Allow shift-selection of boolean attributes MBS-12594: Add shift-click selection in relationship editor Make the medium recording/work checkboxes controlled Add class names to recording/work checkboxes Upgrade Flow to 0.187.0 Increase test timeout after series dialog is submitted MBS-12606: Beta: Relationship editor crashes MBS-12596: Beta: external links editor doesn't work MBS-12607: Add genre page crashes Don't crash relationship dialog if no links types are available Upgrade Flow to 0.186.0 Update translations from Transifex Update POT files using the production database Eslint: autosort imports by path (#2603) MBS-11388: Convert the relationship editors to React Autocomplete: Sync recent entities with Autocomplete2 WS::js::Edit: Return error for invalid date ranges Move is_date_range_valid to MB::S::Validation t/sql/initial.sql: Sync series_type with production Autocomplete2: Use item name for input value DateRangeFieldset: Use "Copy to end date" title string Dialog: Prevent mouse and tab keypress events from propagating Autocomplete2: Add a colon after the label text Autocomplete2: Allow configuring the input label style Autocomplete2: Allow configuring the input class Autocomplete2: Allow passing disabled through initial state Autocomplete2: Allow passing containerClass through initial state Popover: Allow configuring the Dialog className DeletedLink: Allow configuring the className ButtonPopover: Page scrollbar clicks should not close the popover ButtonPopover: Allow configuring disabled, id props Define .buttons-right class Autocomplete2: Get active user from the global JS namespace Autocomplete2: Maintain static items list in set-recent-items Modal: Center horizontally Autocomplete2: Always show menu after clicking the input Add Flow libdefs for tape Skip links when moving focus into dialogs Forward EntityLink props Move MBS-6129 test to linkPhrase.js forGrouping should take orderable_direction into account pThrottle: Remove unused Map Autocomplete2: Handle recent items with fake IDs Autocomplete2: Don't close menu when using the scrollbar Add EMPTY_PARTIAL_DATE constant Move external links state initialization into the component Allow hydrating components with no props Consistently access source entity data from JS Factor out usePagedMediumTable from release pages FieldErrors: Factor out FieldErrorsList Move DISPLAY_NONE_STYLE to common/constants.js Controller::Release: Factor out _load_mediums_limited Allow customizing relationship entity display .flowconfig: turn on unnecessary-invariant lint .eslintrc.yaml: turn off flowtype/generic-spacing WS::js::Edit: Return created relationship IDs WS::js::Edit: Support EDIT_RELATIONSHIPS_REORDER WS::js::Edit: Support linkOrder on EDIT_RELATIONSHIP_CREATE Pass link_type directly to Edit::Relationship::Reorder EnterEditNote.js: allow use as controlled component EnterEdit.js: allow use as controlled component Add missing keys to EntityLink parts Add createFastObjectCloneFunction utility Add script for creating empty core entity objects Factor out numeric uniqueId utility Convert is_database_row_id to JavaScript Change source_type/target_type CoreEntityTypeT Serialize the Catalyst request method Add yearInputRef to FormRowPartialDate Add new `createCompoundField` function createCompoundField -> createCompoundFieldFromObject Allow using div.row styling outside forms Move release-editor specific CSS to release-editor.less Check for empty dates in relationshipDateText expand2react: Remove a use of `any` /ws/js/type-info Change isDateValid to take a partial date object Add sortedFindOrInsert Use existing getSortName in groupRelationships.js Move isLinkTypeDirectionOrderable to own module Update POT files using the production database MBS-12335: Link to attribute docs from reltype docs (#2499) MBS-12592: Convert cdstub/import to React Make InlineSubmitButton reusable MBS-12590: Convert cdstub/logged_in to React Show CD stub logged in error as last option MBS-12591: Actually stop logged-in users from entering CD stubs MBS-12587: Convert cdstub/error to React (#2631) MBS-12582: Convert cdstub/index to React MBS-12580: Convert cdstub/cdstub to React MBS-12581: Convert cdstub/layout and /header to React Make calculateFullToc reusable MBS-12578: Avoid possible ISEs on cdtoc/remove MBS-12577: Convert cdtoc/remove to React Make CDTocLink content default to cdToc.disc Remove now unused TT macro track_duration_changes MBS-12575: Convert cdtoc/attach_confirm to React MBS-12576: Improve erroring with wrong IDs on CDTOC pages MBS-12574: Convert cdtoc/set_durations to React (#2622) MBS-12572: Convert cdtoc/info to React (#2621) MBS-12563: Block smart links: strm.to (#2625) MBS-12567: Fail gracefully when loading unsupported class (#2618) MBS-12589: Return if direct search query times out (#2633) MBS-12586: Adapt Brahms/IRCAM cleanup to new link style (#2629) MBS-12588: Escape user-provided disc ID in regex (#2632) Fix building CSS in production Docker images (#2623) MBS-12584: Block smart links: onerpm.link MBS-12585: Block smart links: withkoji.com MBS-12135: Convert the notes received page to React Add flow types to setCookie Extract reusable getEditHeaderClass function MBS-10364: Convert release merge page to React (#1448) MBS-12562: Redirect row id url to gid url for works too (#2617) Rename edit_template_react now that it's the only one Remove conditional now all edits are React MBS-12134: Convert the cancel edit page to React MBS-12566: Fix incorrect URL shortener detection Remove seemingly unused template Remove unused TT macro medium_description Remove unused TT macro medium_link Remove unused TT macro uri_escape Remove unused TT macro yesno Remove unused TT macro N_ln Remove unused TT macro expand Remove unused TT macro entity_exists Remove unused TT macro link_tag Remove unused TT macro link_isrc Remove unused TT macro link_iswc Remove unused TT macro link_searchable_property Remove unused TT macro entity_label Remove unused TT macro format_entity_type_name Remove unused TT macro format_plural_entity_type_name Remove unused TT macro quality_name Remove unused TT macro vote_tally Remove unused TT macro error Remove unused TT macro relationship_target_links Remove unused TT macro release_event Remove unused TT macro format_isni Remove unused TT macro link_type_cardinality_name Remove unused TT macro orderable_direction_name Remove unused TT macro bugtracker_url Remove no longer embedded Aliases Remove no longer embedded GroupedTrackRelationships Remove no longer embedded RelationshipsTable Remove no longer embedded Annotation Remove no longer embedded Relationship & Relationships Remove no longer embedded WikipediaExtract Remove no longer embedded ReleaseEventsDiff Remove no longer embedded RelationshipDiff Remove no longer embedded CritiqueBrainzReview Move isShortenedUrl to its own module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-12780
This was checking for the
entity0andentity1passed outside therelationshipitself - which we were also adding to the relationship data for display. But we were only passing this if the ID was not defined in the first place, so this check was nonsensical AFAICT. In fact, I cannot find any reason to passentity0andentity1outside therelationship, since we're already passing them inside it.I'm also removing the
source_typeandtarget_typethat I had added in 9b0eae3 since AFAICT we're again not using those, but the ones inside therelationshipobject.I tested this with
/edit/92070356(the one where both sides were removed that triggered the ticket), with a new URL being added to a new release (to make sure release preview does still say "will be created"), and with/edit/15273082(the edit that triggered #1589) to make sure it still works for deleted reltypes. Please do have a quick think on whether there might be some other case I didn't think of that could break with this :)