Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-12841 / MBS-8242: Link to edit and relationship docs from edits #2876

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Dec 14, 2023

  1. Drop generic Edit Types doc link from edit sidebar

    This is only shown when viewing one edit at a time, and does not point
    to docs for the specific edit either, but to a generic page.
    It should be replaced by a documentation link that is visible
    from the edit header on any edit view.
    reosarevok committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    9b64949 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. MBS-12841: Link to specific edit type docs from edits

    This adds a link to the doc page for the specific edit type in question
    to the header of every edit, be it on an edit list or
    on the edit page itself.
    This replaces the generic "Edit Types" link on the sidebar
    (not shown on edit lists) that was removed in the previous commit.
    reosarevok committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2b5bf76 View commit details
    Browse the repository at this point in the history
  2. Properly load LinkType for Relationship::Delete

    This was probably copied from Create or other place where the structure
    was different, but here {link} is inside {relationship}.
    reosarevok committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    309f008 View commit details
    Browse the repository at this point in the history
  3. Move getRelationshipLinkType to /edit

    I'm using this outside the relationship editor in the next commit,
    so it seems cleaner to move it here.
    reosarevok committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    8472078 View commit details
    Browse the repository at this point in the history
  4. MBS-8242: Link to specific relationship type docs from rel edits

    This adds a link to the doc page(s) for the relationship type(s)
    involved in a relationship edit (add, edit or remove),
    and lists the type descriptions for a basic overview.
    It seems very useful to have direct links to the documentation
    (often including specific guidelines)
    directly in the place people need to vote on the changes from.
    
    We pass an array to allow multiple types in EditRelationship;
    we pass the rels through a Set to remove duplicates
    when EditRelationship does not change the rel type.
    reosarevok committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    652523f View commit details
    Browse the repository at this point in the history