MBS-13062: Implementing the footer redesign #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
santiagofn
force-pushed
the
akshat/footer-revamp
branch
from
8e4c021
to
0a92f16
Compare
|
@brainzbot, add to whitelist |
santiagofn
force-pushed
the
akshat/footer-revamp
branch
2 times, most recently
from
1d0e331
to
c4eee04
Compare
|
Updated screenshots:
|
|
So, the failing test is now passing:
But a new error arises... which I don't know how to solve: @reosarevok maybe you can give me an insight about this? Thanks! |
santiagofn
force-pushed
the
akshat/footer-revamp
branch
2 times, most recently
from
52098e1
to
7897763
Compare
santiagofn
changed the title
- Created a file with the raw input data used to build the footer - Most parts of the footer were moved to their own components
- Row-cols is used to define the layout on different breakpoints - Added margins on breakpoints < xl - Fixed margins in first block
- Added text about MusicBrainz - Change channel's list line-height - Added gray style - Removed <bold> from links
santiagofn
force-pushed
the
akshat/footer-revamp
branch
from
7897763
to
522ebd3
Compare
|
@brainzbot, retest this please |
|
I'm not sure tbh. I hope it's not something stupid like [] in the test title breaking something? :) |
|
Merging to the footer revamp PR for now because we need to resolve conflicts and it makes sense to resolve them at one place |
akshaaatt
merged commit b52778b
into
metabrainz:akshat/footer-revamp
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm updating the branch that @akshaaatt created, as it was in #2439, with some changes & fixes:
MBS-4555.json5was failing because it couldn't find an element. Fixed it creating a newidThe new looks: