Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-13102: Update alias locales to Unicode CLDR 43 #2953

Merged
merged 3 commits into from May 29, 2023

Conversation

yvanzo
Copy link
Contributor

@yvanzo yvanzo commented May 26, 2023

Problem MBS-13102

Keep up to date with Unicode CLDR for alias locales.

Solution

  • Bump Datetime-Locale from 1.37 to 1.39 (CLDR from 42 to 43);
  • Rebuild the list of locales for aliases;
  • Also rebuild CPAN snapshots, all minor seemingly impact-less updates.

Checklist for author

  • Review CLDR 43 release notes;
  • Review (seemingly impact-less) changes for all (minor) updates in CPAN snapshot files.
    Tip:
    git show --no-color | sed -n 's_^+  \([^ ]*\)-[0-9].*$_https://metacpan.org/dist/\1/changes_p' | sort -u | xargs firefox

Testing

Manually:

  • Opened an artist alias page;
  • Edited an artist alias and checked some new locales are indeed in the list.

Also checked server logs.

Action (after merge)

  • Nothing about existing aliases as no locale codes are removed or altered;
  • Nothing about test image because changes to updated packages are minor enough.

@yvanzo
Copy link
Contributor Author

yvanzo commented May 26, 2023

About the _001/world locales: These are international variants. See this blog post about World English. We currently have only 65 aliases with such locale.

Copy link
Member

@reosarevok reosarevok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me with the suggested Greek change.

@yvanzo
Copy link
Contributor Author

yvanzo commented May 26, 2023

Created MBS-13103 about 001/world variants.

@yvanzo
Copy link
Contributor Author

yvanzo commented May 29, 2023

Bumped to DateTime-Locale 1.39 that fixed el_polyton.
Re-tested the same way, Greek Polytonic now appears in the alias locale dropdown.

@reosarevok
Copy link
Member

The PR still shows just "Greek", did you forget to commit/push something? :)

./script/dump_locales.pl > ./root/static/scripts/common/constants/locales.json
./docker/generate_cpanfile_snapshot.sh
./docker/generate_cpanfile_snapshot.sh docker/musicbrainz-test-database/cpanfile

All updates other than Datetime-Locale are minor and expected impactless.
@yvanzo
Copy link
Contributor Author

yvanzo commented May 29, 2023

Good catch, fixed it!

@yvanzo yvanzo merged commit 8e94ecc into metabrainz:master May 29, 2023
2 checks passed
@yvanzo yvanzo deleted the cldr-43-mbs-13102 branch May 29, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants