MBS-13152: Special purpose language: No linguistic content (zxx) #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For what it's worth, the po files should not be changed by hand, and the language renaming, if we decide to do it, should be done by an admin via the site (languages are not hardcoded in code). Is there a ticket and/or forum thread for this with any specific discussion? |
|
I have created https://tickets.metabrainz.org/browse/MBS-13152 for this, then. |
reosarevok
reviewed
Jul 3, 2023
|
I have removed
Maybe the |
|
Yes, the |
|
I see I forgot a
Are they OK? |
Like [Artificial (Other)] (qaa) Like [Multiple languages] (mul) Like [No lyrics] (same zxx) No linguistic language should be renamed to [No linguistic language] and should appear in release language list (select combo) after [Artificial (Other)] instead of between Niuean and Nogai
|
I have changed 2 commits into 1. |
reosarevok
added a commit
that referenced
this pull request
Jul 4, 2023
* master: Special purpose language: No linguistic content (zxx) (#2973) MBS-13130: Use new pencil icon (#2970) MBS-13131: Move staticbrainz to static.metabrainz for instruments (#2967) Use Perl::Critic::Moose::RequireCleanNamespace (#2702) Add tests for who can add edit notes Use $edit_id over $edit->id Remove useless newline Simplify and better document email test Separate the transaction test Get rid of too long lines in note-adding test Use the standard $c->model syntax in Vote/EditNote tests Split all into two separate thematic tests Test more cases where voting should be blocked Slight improvements to test labels Split all into two separate thematic tests Get rid of too long lines in expiration test Move all no-vote email testing into the email test Use $edit_id rather than doing $edit->id every time Use $c over $test->c for brevity Move vote stats check to own subtest MBS-13100: Readd beginner voting restrictions Follow Perl::Critic::Policy::BuiltinFunctions::RequireBlockMap with exceptions Follow Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep Follow Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidMap Add Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidGrep Move isShortenedUrl.js test to its own file Move formatSetlist.js test to its own file Improve test labels for fullwidthLatin tests Allow null and undefined in fullwidthLatin functions Separate fullwidthLatin tests for each function Move fullwidthLatin.js tests to their own file Tighten the Flow requirements for formatUserDate Move formatUserDate.js tests to their own file Fix eslint issues in areDatesEqual test Move areDatesEqual.js tests to their own file Amend test that was forbidden by Flow Fix eslint issues in compareDates test Move compareDates.js tests to their own file Fix eslint issues in formatDatePeriod test Move formatDatePeriod.js tests to their own file Allow undefined day / month / year and PartialDate in Flow Fix eslint issues in formatDate test Move formatDate.js tests to their own file Fix eslint issues in parseDate test Move parseDate.js tests to their own file Fix eslint issues in formatTrackLength test Move formatTrackLength.js tests to their own file Fix flow issues in age test Fix eslint issues in age test Follow Perl::Critic::Policy::BuiltinFunctions::ProhibitUniversalIsa Follow Perl::Critic::Policy::BuiltinFunctions::ProhibitStringySplit Follow Perl::Critic::Policy::BuiltinFunctions::ProhibitReverseSortBlock Remove unneeded my MBS-12026: Still change deleted editor votes if they lack privs MBS-12942: Also indicate if target has pending edits in rels editor MBS-12942: Use new pending edits for rel icon MBS-12951: Use new + and x icons (#2964) MBS-13119: Readd anchor link to CDTocReleaseList (#2961) Move age.js tests to their own file Allow undefined day / month / year in Flow Fix eslint issues in dates test Move dates.js tests to their own file Remove Entity::CoreEntity (#2960) Add missing Role::CSRFToken to Form::User::Contact MBS-12660: Convert user contact form to React
jesus2099
changed the title
reosarevok
added a commit
that referenced
this pull request
Jul 10, 2023
* beta: Fix release search log flood since commit e38d8e9 (#2978) Drop decoda.com from malware domain list Special purpose language: No linguistic content (zxx) (#2973) MBS-13130: Use new pencil icon (#2970) MBS-13131: Move staticbrainz to static.metabrainz for instruments (#2967) Use Perl::Critic::Moose::RequireCleanNamespace (#2702) Add tests for who can add edit notes Use $edit_id over $edit->id Remove useless newline Simplify and better document email test Separate the transaction test Get rid of too long lines in note-adding test Use the standard $c->model syntax in Vote/EditNote tests Split all into two separate thematic tests Test more cases where voting should be blocked Slight improvements to test labels Split all into two separate thematic tests Get rid of too long lines in expiration test Move all no-vote email testing into the email test Use $edit_id rather than doing $edit->id every time Use $c over $test->c for brevity Move vote stats check to own subtest MBS-13100: Readd beginner voting restrictions Follow Perl::Critic::Policy::BuiltinFunctions::RequireBlockMap with exceptions Follow Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep Follow Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidMap Add Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidGrep Move isShortenedUrl.js test to its own file Move formatSetlist.js test to its own file Improve test labels for fullwidthLatin tests Allow null and undefined in fullwidthLatin functions Separate fullwidthLatin tests for each function Move fullwidthLatin.js tests to their own file Tighten the Flow requirements for formatUserDate Move formatUserDate.js tests to their own file Fix eslint issues in areDatesEqual test Move areDatesEqual.js tests to their own file Amend test that was forbidden by Flow Fix eslint issues in compareDates test Move compareDates.js tests to their own file Fix eslint issues in formatDatePeriod test Move formatDatePeriod.js tests to their own file Allow undefined day / month / year and PartialDate in Flow Fix eslint issues in formatDate test Move formatDate.js tests to their own file Fix eslint issues in parseDate test Move parseDate.js tests to their own file Fix eslint issues in formatTrackLength test Move formatTrackLength.js tests to their own file Fix flow issues in age test Fix eslint issues in age test Follow Perl::Critic::Policy::BuiltinFunctions::ProhibitUniversalIsa Follow Perl::Critic::Policy::BuiltinFunctions::ProhibitStringySplit Follow Perl::Critic::Policy::BuiltinFunctions::ProhibitReverseSortBlock Remove unneeded my MBS-12026: Still change deleted editor votes if they lack privs MBS-12942: Also indicate if target has pending edits in rels editor MBS-12942: Use new pending edits for rel icon MBS-12951: Use new + and x icons (#2964) MBS-13119: Readd anchor link to CDTocReleaseList (#2961) Move age.js tests to their own file Allow undefined day / month / year in Flow Fix eslint issues in dates test Move dates.js tests to their own file Remove Entity::CoreEntity (#2960) Add missing Role::CSRFToken to Form::User::Contact MBS-12660: Convert user contact form to React
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes along MBS-13152
[Artificial (Other)](qaa)[Multiple languages](mul)[No lyrics](samezxx)No linguistic language(zxx) should be renamed to[No linguistic language](zxx) and should thus appear in release language list (select combo) after[Multiple languages](Frequently used)[Artificial (Other)], instead of betweenNiueanandNogai.I guess it also requires a Database edit of the stored label in languages table.
Maybe I am missing some files.