MBS-13149 / MBS-13153 / MBS-13156 / MBS-13157: More guess case changes #2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wanted to lowercase it inside parens but it does not seem like it did the trick. Changed it a bit to work like a_cappella, which does work (this also makes it consistent with "reedit")
Also doing the same for the equivalent "remastered"
We need to use /g here or it will only fix the first case per title (see tests for somewhat contrived examples).
reosarevok
added
QoL
|
@brainzbot, retest this please |
mwiencek
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-13153 and MBS-13157, implement MBS-13149 and MBS-13156
Problem
The words "remaster" ("remastered") and "refix" are pretty much always ETI and should be treated as such by guess case. Same for "re-edit", which we already try to cover, but buggily.
While looking into these I also noticed we don't use global regexes enough, causing issues if the same word appears twice (uncommon, but not impossible).
Solution
I added all of the new words to the list of words which are put into parens if seen at the end of the title, and lowercased if in parens.
I fixed the re-edit check and made it behave differently inside and outside parens.
I made the a cappella and OC ReMix checks global so that it checks more than once per title.
Testing
Added a basic test for each case.