MBS-13160: Rename "legal name" on artist page to "performance name of" #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We renamed the relationship text for "performs as" with STYLE-2328 but the display on the artist overview page was still hardcoded to "Legal name". This renames it to "Performance name of" (as in the relationship) in the case where we follow this relationship (which no longer mandates it must be a legal name). "Legal name" is kept for actual legal name alias display. I wasn't sure what'd be a good name for the no-longer-legalName, ended up going with baseName since it's the base of the grouping of names for the artist.
mwiencek
approved these changes
Jul 10, 2023
reosarevok
added a commit
that referenced
this pull request
Jul 25, 2023
* master: Add tests for note change history Move ChangeNote test to new EditNote folder MBS-13094: Allow admins to browse edit note changes MBS-13057: Show info about application to be revoked in /revoke-access MBS-13058: 404 /applications/revoke-access if token does not exist Rename application files to match components MBS-13177: Show label events on label rels page (#2989) Add autoComplete to RegisterForm MBS-12664: Convert the Register page to React Add autoComplete to ResetPassword MBS-12663: Convert Reset password page to React Standardize page title vs h2 heading MBS-13171: Add support for Boomkat URLs (#2985) Add autoComplete to ChangePassword MBS-13112: Hide username field when changing password MBS-12662: Convert Change password page to React MBS-13113: Show in attribute page if it supports free text (#2957) MBS-13183: Add CORS support to Wikipedia extracts Refactor: Get the current response once for all Do not ISE on /delete for invalid attribute ID Add tests for attribute deletion pages MBS-13106: Fix ISE on trying to delete language/script MBS-13105: Fix ISE on trying to delete language MBS-13092: Support Apple Music song links (#2975) MBS-13167: Show last granted token date for auth applications (#2983) MBS-13173: Also allow daily.bandcamp.com interviews (#2986) Add diagram focused on finding song authors Add diagram focused on tagging audio files Add a soup diagram with all MB/CAA tables Regenerate graphs and images for schema 28 Clarify wording on (primary) entity (type) Typo: missing article Fix oversight in phrasing Fix oversight when dropping "core" occurrences Fix the list of stuff common to primary entities Drop or replace unneeded and meaningless “core” Fix and unifiy phrasing of diagram comments Fix typo+s Fix wording as link stands for relationship Fix punctuation Fix punctuation Add a link anchor to Build materialized tables Fix comment of the detailed entity network diagram MBS-13162: Handle Threads links (#2981) MBS-13168: Add autoselect for BookBrainz series (#2980) MBS-13160: Rename "legal name" on artist page to "performance name of" (#2979) MBS-13115: Move annotation preview button to the left of Enter (#2976) MBS-13157: Use global flag for preprocessing MBS-13149: Lowercase refix in guess case MBS-13156: Lowercase remaster in guess case MBS-13153: Fix broken re-edit guess case MBS-13116: Also list abstaining votes in vote tally MBS-12670: Convert the Delete user page to React MBS-13111: Hide list of autoeditor election voters during vote
reosarevok
added a commit
that referenced
this pull request
Aug 7, 2023
* beta: MBS-13098: Process cover art params for seeding (#2977) Simplify anyCombinationOf MBS-13169: Use SVG over PNG for new icons (#2984) MBS-13079: Add statistics for release groups with no type set (#2936) MBS-12886: Restrict Bandcamp /(album|track) to "get the music" rels Widen the combination options for Soundcloud URLs Remove now unused TT user profile layout Also allow other form components to take React.Node labels MBS-12671: Convert Edit user page to React Add tests for note change history Move ChangeNote test to new EditNote folder MBS-13094: Allow admins to browse edit note changes MBS-13057: Show info about application to be revoked in /revoke-access MBS-13058: 404 /applications/revoke-access if token does not exist Rename application files to match components MBS-13177: Show label events on label rels page (#2989) Add autoComplete to RegisterForm MBS-12664: Convert the Register page to React Add autoComplete to ResetPassword MBS-12663: Convert Reset password page to React Standardize page title vs h2 heading MBS-13171: Add support for Boomkat URLs (#2985) Add autoComplete to ChangePassword MBS-13112: Hide username field when changing password MBS-12662: Convert Change password page to React MBS-13113: Show in attribute page if it supports free text (#2957) MBS-13183: Add CORS support to Wikipedia extracts Refactor: Get the current response once for all Do not ISE on /delete for invalid attribute ID Add tests for attribute deletion pages MBS-13106: Fix ISE on trying to delete language/script MBS-13105: Fix ISE on trying to delete language MBS-13092: Support Apple Music song links (#2975) MBS-13167: Show last granted token date for auth applications (#2983) MBS-13173: Also allow daily.bandcamp.com interviews (#2986) Add diagram focused on finding song authors Add diagram focused on tagging audio files Add a soup diagram with all MB/CAA tables Regenerate graphs and images for schema 28 Clarify wording on (primary) entity (type) Typo: missing article Fix oversight in phrasing Fix oversight when dropping "core" occurrences Fix the list of stuff common to primary entities Drop or replace unneeded and meaningless “core” Fix and unifiy phrasing of diagram comments Fix typo+s Fix wording as link stands for relationship Fix punctuation Fix punctuation Add a link anchor to Build materialized tables Fix comment of the detailed entity network diagram MBS-13162: Handle Threads links (#2981) MBS-13168: Add autoselect for BookBrainz series (#2980) MBS-13160: Rename "legal name" on artist page to "performance name of" (#2979) MBS-13115: Move annotation preview button to the left of Enter (#2976) MBS-13157: Use global flag for preprocessing MBS-13149: Lowercase refix in guess case MBS-13156: Lowercase remaster in guess case MBS-13153: Fix broken re-edit guess case MBS-13116: Also list abstaining votes in vote tally MBS-12670: Convert the Delete user page to React MBS-13111: Hide list of autoeditor election voters during vote Refactor: Rename `$*_sql` flag variables Refactor: Rename `$mirror` to `$applying_change_sql` Refactor: Rename `$sql2` to `$feching_change_sql` Add comments to processing replication changes DRY update-date-period actions MBS-12964: Allow specifying dates when batch-creating works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-13160
Problem
We renamed the relationship text for "performs as" with STYLE-2328 but the display on the artist overview page was still hardcoded to "Legal name".
Solution
This renames the hardcoded text to "Performance name of" (as in the relationship) in the case where we follow this relationship (which no longer mandates it must be a legal name). "Legal name" is kept for actual legal name alias display.
I wasn't sure what'd be a good name for the no-longer-
legalName, ended up going withbaseNamesince it's the base of the grouping of names for the artist.Testing
Manually, on the artist from the ticket.