Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-8952: Can rename recordings via autocomplete #3039

Merged
merged 1 commit into from
Oct 17, 2023

Commits on Sep 27, 2023

  1. MBS-8952: Can rename recordings via autocomplete

    I was able to reproduce this using the steps in
    https://tickets.metabrainz.org/browse/MBS-13021.
    
    The primary issue is that recordings from the search server don't include a
    database row ID, so the `if (currentSelection.id)` check modified here didn't
    clear the selection when modifying text. The `else` branch updated the
    recording name with the entered text and notified all subscribers of the
    autocomplete observable.
    
    Checking for `currentSelection.gid` there fixes the bug. I also changed the
    edit generation code to revert any recording changes if the necessary settings
    to update them aren't enabled.
    mwiencek committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    78bca57 View commit details
    Browse the repository at this point in the history