Fix Selenium test broken by MBS-13420 #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
added
the
Regression/Beta
reosarevok
added a commit
that referenced
this pull request
Jan 25, 2024
* master: Update POT files using the production database MBS-13413: Allow using "Add/Remove note" with keyboard (#3133) Improve AC bubble wording (#3131) MBS-13438: Restrict and validate Qobuz URLs (#3152) MBS-13402: Unbreak unsetting work order in release rel editor (#3153) MBS-13346: Support GTIN-14 barcodes (#3078) Fix warning in Chrome submitting the ExternalLinkAttributeDialog MBS-11910: Allow editing rel credits in the external links editor MBS-13452: Add patronage autoselect for Buy Me a Coffee URLs (#3148) Add selenium test to check vote + note submission Add basic test for is_valid_edit_note MBS-13432: Also check if subsequent edit notes are valid MBS-13432: Also check if non-required note is valid MBS-13432: Ignore format chars for is_valid_edit_note MBS-13459: Add RISM links to sidebar MBS-13459: Add RISM to whitelist for other databases Sort pixiv and progarchives tests correctly Amend 2049127: Test Bugs! track URL too Amend 2049127: Add Bugs! URL validation tests Amend f601aa5: Drop bad Bugs! URL test input Amend 470fd28: Fix oversight in Genie URL test Amend 91ba97f: Fix code style per eslint Amend 5d51a23: Fix code style per eslint Amend 9cb1669: Fix per eslint max-len rule Amend e76ec04: Disable eslint for unused vars Improve website display in Spanish (Latin America) Bump musicbrainz-tests image versions Amend d79a2f6: Update locales for Selenium test Avoid `rm` error messages by testing file presence MBS-13425: Normalize entities.oclc.org to id.oclc.org (#3143) Fix starting chrome service for web tests Restore failing CircleCI tests on error MBS-13443: Properly display HTML setlist codes (#3145) Fix Flow failures (#3144) MBS-12879: Block Bandcamp /videoframe links (#2829) Don't store incremental JSON dumps in a local volume (#3142) Drop now unneeded manual import of statistics i18n Auto-import N_l_statistics/N_lp_statistics in JS MBS-13327: Don't unlink recording from track when removing feat. artists (#3136) MBS-13419: improve variety of cleanup tests MBS-13419: fix match regex to clean non-HTTPS links Bump musicbrainz-tests image versions Drop country code for Greek and Spanish in tests Avoid server translation domain in statistics code Fix ESLint max-len warnings the previous commit Stop aliasing imports of *l*_statistics Add missing N_lp_statistics MBS-13429: Autoselect and validate Metacritic RG links as reviews (#3137) MBS-13419: clean up OTOTOY URLs MBS-13419: simplify validation regex MBS-13419: Apply only_valid_entity_types commit suggestions Fix rendering translations in statistics timeline Fix rendering translations in MusicBrainz History MBS-13431 (fin): Use statistics expanded variants MBS-13431 (pre): Parse statistics exp/texp MBS-13431 (pre): Auto-import statistics exp/texp MBS-13431 (pre): Add statistics expanded variants Fix deleted entity spacing in subscription email (#3140) MBS-13419: Add validation for OTOTOY URLs Fix Selenium test broken by MBS-13420 (#3138) MBS-13415: Add sidebar for OTOTOY URLs Add a test for non-existent references in unreferenced_row_log Remove unneded sprintf calls MBS-12636: Do not remove unreferenced ACs with pending edits
mwiencek
pushed a commit
to mwiencek/musicbrainz-server
that referenced
this pull request
Jan 31, 2024
mwiencek
pushed a commit
to mwiencek/musicbrainz-server
that referenced
this pull request
Feb 2, 2024
mwiencek
added a commit
that referenced
this pull request
Feb 8, 2024
* production: Remove `cache_aware_c` and mock caches Clear release from cache when ASIN is updated Cache redirected gids MBS-13449: Reimplement transactional cache without database locks Clear the cache after each test in `t::Context` Make use of `cache_aware_c` in `Data::Artist` test Set `fresh_connector` in `_build_cache_aware_context` Pass ID list around through `_add_to_cache` Use an actual GID in the `GIDEntityCache` tests Change `@ids` filter in `Data::Role::EntityCache` to match `Data::Entity` Add `_cache_prefix` to `Data::Role::EntityCache` Change `_add_to_cache` to accept a hash ref Rename variable for clarity Change `Data::Artist::merge` signature to match others Fix Selenium test broken by MBS-13420 (#3138)
mwiencek
added a commit
that referenced
this pull request
Feb 8, 2024
* beta: Remove `cache_aware_c` and mock caches Clear release from cache when ASIN is updated Cache redirected gids MBS-13449: Reimplement transactional cache without database locks Clear the cache after each test in `t::Context` Make use of `cache_aware_c` in `Data::Artist` test Set `fresh_connector` in `_build_cache_aware_context` Pass ID list around through `_add_to_cache` Use an actual GID in the `GIDEntityCache` tests Change `@ids` filter in `Data::Role::EntityCache` to match `Data::Entity` Add `_cache_prefix` to `Data::Role::EntityCache` Change `_add_to_cache` to accept a hash ref Rename variable for clarity Change `Data::Artist::merge` signature to match others Fix Selenium test broken by MBS-13420 (#3138) Translated using Weblate (Lithuanian) Translated using Weblate (German) Translated using Weblate (Spanish) Translated using Weblate (Lithuanian) Translated using Weblate (French) Translated using Weblate (Italian) Translated using Weblate (Spanish) Translated using Weblate (Korean) Update translation files Translated using Weblate (Dutch) Translated using Weblate (Dutch) Translated using Weblate (Czech) Translated using Weblate (Dutch) Translated using Weblate (German) Translated using Weblate (Lithuanian)
reosarevok
added a commit
that referenced
this pull request
Feb 12, 2024
* beta: Translated using Weblate (Spanish) Translated using Weblate (Italian) Translated using Weblate (Italian) Added translation using Weblate (Persian) Added translation using Weblate (Persian) Translated using Weblate (French) Translated using Weblate (Lithuanian) Translated using Weblate (Italian) Update translation files Translated using Weblate (Lithuanian) Remove `cache_aware_c` and mock caches Clear release from cache when ASIN is updated Cache redirected gids MBS-13449: Reimplement transactional cache without database locks Clear the cache after each test in `t::Context` Make use of `cache_aware_c` in `Data::Artist` test Set `fresh_connector` in `_build_cache_aware_context` Pass ID list around through `_add_to_cache` Use an actual GID in the `GIDEntityCache` tests Change `@ids` filter in `Data::Role::EntityCache` to match `Data::Entity` Add `_cache_prefix` to `Data::Role::EntityCache` Change `_add_to_cache` to accept a hash ref Rename variable for clarity Change `Data::Artist::merge` signature to match others Fix Selenium test broken by MBS-13420 (#3138) Update POT files using the production database Translated using Weblate (Lithuanian) Translated using Weblate (German) Translated using Weblate (Spanish) Translated using Weblate (Lithuanian) Translated using Weblate (French) Translated using Weblate (Italian) Translated using Weblate (Spanish) Translated using Weblate (Korean) Update translation files MBS-13465: Prefer non-raw images when displaying front release group cover art (#3154) Add context to [removed] strings Drop contact email from strings (#3160) Add context to [none] barcodes (#3162) Add context to [unknown] strings (#3161) Add context to "cancelled" for events (#3159) Standardize valid ISRC string Add context to "Time" strings (#3156) Remove unneded addColonText imports Remove colons from Type strings Amend e4e593c: Block add-on code until MBS-13468 Amend 1f10fee: Drop dead code after MBS-3856 Fix JSON-LD serialization of release’s barcode Share real barcodes in JS/Perl validation CI tests Recognize 2-digit and 5-digit GTIN barcode add-ons Recognize GTIN-8 (EAN-8) barcode in release editor Amend 9649c62: Drop supporting GTIN-14 in tests Describe more accurately barcode validation tests Nuance the JS client-side validation of barcode Make barcode submission API error more accurate Refactor barcode submission API WS/2 tests Refactor: Rename *valid_ean* subs to *valid_gtin* Drop submitting GINC/GSIN/SSCC barcode through API Refactor barcode check digit validation in JS Refactor: Move EAN check digit validation to a sub Update POT files using the production database MBS-13413: Allow using "Add/Remove note" with keyboard (#3133) Improve AC bubble wording (#3131) MBS-13438: Restrict and validate Qobuz URLs (#3152) MBS-13402: Unbreak unsetting work order in release rel editor (#3153) MBS-13346: Support GTIN-14 barcodes (#3078) Fix warning in Chrome submitting the ExternalLinkAttributeDialog MBS-11910: Allow editing rel credits in the external links editor Translated using Weblate (Dutch) Translated using Weblate (Dutch) Translated using Weblate (Czech) Translated using Weblate (Dutch) Translated using Weblate (German) Translated using Weblate (Lithuanian) MBS-13452: Add patronage autoselect for Buy Me a Coffee URLs (#3148) Add selenium test to check vote + note submission Add basic test for is_valid_edit_note MBS-13432: Also check if subsequent edit notes are valid MBS-13432: Also check if non-required note is valid MBS-13432: Ignore format chars for is_valid_edit_note MBS-13459: Add RISM links to sidebar MBS-13459: Add RISM to whitelist for other databases Sort pixiv and progarchives tests correctly Amend 2049127: Test Bugs! track URL too Amend 2049127: Add Bugs! URL validation tests Amend f601aa5: Drop bad Bugs! URL test input Amend 470fd28: Fix oversight in Genie URL test Amend 91ba97f: Fix code style per eslint Amend 5d51a23: Fix code style per eslint Amend 9cb1669: Fix per eslint max-len rule Amend e76ec04: Disable eslint for unused vars Improve website display in Spanish (Latin America) Bump musicbrainz-tests image versions Amend d79a2f6: Update locales for Selenium test Avoid `rm` error messages by testing file presence MBS-13425: Normalize entities.oclc.org to id.oclc.org (#3143) Fix starting chrome service for web tests Restore failing CircleCI tests on error MBS-13443: Properly display HTML setlist codes (#3145) Fix Flow failures (#3144) MBS-12879: Block Bandcamp /videoframe links (#2829) Don't store incremental JSON dumps in a local volume (#3142) Drop now unneeded manual import of statistics i18n Auto-import N_l_statistics/N_lp_statistics in JS MBS-13327: Don't unlink recording from track when removing feat. artists (#3136) MBS-13419: improve variety of cleanup tests MBS-13419: fix match regex to clean non-HTTPS links Bump musicbrainz-tests image versions Drop country code for Greek and Spanish in tests Avoid server translation domain in statistics code Fix ESLint max-len warnings the previous commit Stop aliasing imports of *l*_statistics Add missing N_lp_statistics MBS-13429: Autoselect and validate Metacritic RG links as reviews (#3137) MBS-13419: clean up OTOTOY URLs MBS-13419: simplify validation regex MBS-13419: Apply only_valid_entity_types commit suggestions Fix rendering translations in statistics timeline Fix rendering translations in MusicBrainz History MBS-13431 (fin): Use statistics expanded variants MBS-13431 (pre): Parse statistics exp/texp MBS-13431 (pre): Auto-import statistics exp/texp MBS-13431 (pre): Add statistics expanded variants Fix deleted entity spacing in subscription email (#3140) MBS-13419: Add validation for OTOTOY URLs Translated using Weblate (Spanish (Latin America)) Translated using Weblate (Swedish) Translated using Weblate (Norwegian Bokmål) Translated using Weblate (Hebrew) Translated using Weblate (Dutch) Translated using Weblate (German) Translated using Weblate (Dutch) Translated using Weblate (German) Translated using Weblate (Italian) Translated using Weblate (Italian) Update translation files Fix Selenium test broken by MBS-13420 (#3138) Update POT files using the production database Standardize InstrumentsWithoutWikidata title Update POT files using the production database Translated using Weblate (Catalan) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (Japanese) Translated using Weblate (Greek) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (Slovak) Translated using Weblate (Italian) Translated using Weblate (Russian) Translated using Weblate (Spanish) Translated using Weblate (French) Translated using Weblate (German) Translated using Weblate (Lithuanian) Translated using Weblate (Spanish) Translated using Weblate (Dutch) MBS-13414: Normalize x.com URLs to twitter.com (#3134) MBS-13420: Support Bandcamp /discover tag links (#3135) MBS-13415: Add sidebar for OTOTOY URLs MBS-7028: Add "disambiguation" field to list filters Improve flow typing MBS-12799: Add video flag to Recordings filter Translated using Weblate (Dutch) Translated using Weblate (French) Translated using Weblate (German) Translated using Weblate (French) Translated using Weblate (Dutch) Translated using Weblate (German) Translated using Weblate (Dutch) Translated using Weblate (French) Translated using Weblate (German) Translated using Weblate (Italian) Translated using Weblate (Dutch) Translated using Weblate (French) Translated using Weblate (Estonian) Translated using Weblate (French) Translated using Weblate (French) Translated using Weblate (French) Translated using Weblate (French) Translated using Weblate (Estonian) Translated using Weblate (French) Translated using Weblate (French) Translated using Weblate (Estonian) Translated using Weblate (Dutch) Translated using Weblate (French) Translated using Weblate (French) Translated using Weblate (Dutch) Translated using Weblate (German) Translated using Weblate (Italian) Translated using Weblate (Estonian) Translated using Weblate (German) Stop explicitly importing l_admin MBS-13117: Stop translating even more admin strings Avoid using multiple with in misc files Avoid using multiple with in EditSearch:: files MBS-13405: Also infer rel dirs when adding artists (#3127) Remove bogus evalnochange stats (#3128) Improve Testing section comment Rephrase action example as in other PR sections Clarify action section is for after merging the PR Dedicate checklist template to PR draft progress Move documenting to a PR template section Reformat and mention what is being tested on pages Mention both automated tests and missing tests Add testing section to PR template MBS-12684: Block trying to add a collaborator twice (#2712) MBS-12775: Convert the release Disc Ids page to React Create cdtoc/utils and make reusable areFormattedLengthsEqual MBS-13401: Also load data quality for track releases (#3124) Avoid using multiple with in Script:: files Avoid using multiple with in WebService:: files Don't call extends inside BEGIN on Server.pm Don't call extends inside BEGIN for translation files Don't call extends inside BEGIN for controllers Simplify the $artist_name check MBS-12802: Use localize_error for artist credit errors Make localize_error a reusable util Add a test for non-existent references in unreferenced_row_log Remove unneded sprintf calls MBS-12636: Do not remove unreferenced ACs with pending edits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this test when implementing #3135