MBS-12359: Refactor _columns implementation in data model #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the implementation of _columns to list each column on one row, and turns it into a lazy Moose attribute using a builder in order to cache the result of the join call.
reosarevok
force-pushed
the
MBS-12359
branch
from
39167d5
to
cee6ad8
Compare
mwiencek
approved these changes
May 3, 2024
mwiencek
merged commit 2f89076
into
metabrainz:schema-change-2024-q2
2 of 3 checks passed
yvanzo
added a commit
that referenced
this pull request
May 13, 2024
* schema-change-2024-q2: MBS-11962: Update privileges for all database users on schema changes Add `@FULL_SCHEMA_LIST` to constants Split upgrade script for MBS-13514 Remove `CONCURRENTLY` from inside transaction blocks MBS-13421: Add support for genre collections (#3183) Fix a couple issues with the Solr test service Set a new musicbrainz-tests tag for the schema change CheckSchemaMigration.sh: restore previous t/sql/initial.sql Fix installing pending.so MBS-13403: Drop unused priority column from link_type (#3179) MBS-12359: Refactor _columns implementation in data model (#3192) MBS-13361: Require PostgreSQL 16 (#3234) MBS-13514: Support 6-digit label codes (#3208)
yvanzo
added a commit
that referenced
this pull request
May 13, 2024
* master: Update POT files using the production database Update Yarn version to the latest 4.2.2 Fix installing our xgettext-js fork using Yarn v4 MBS-11962: Update privileges for all database users on schema changes Add `@FULL_SCHEMA_LIST` to constants Split upgrade script for MBS-13514 Amend 2e89f39: Limit to USER triggers Remove reference to `a_ins_instrument` trigger from t/sql/initial.sql Remove `CONCURRENTLY` from inside transaction blocks MBS-13421: Add support for genre collections (#3183) Fix a couple issues with the Solr test service Set a new musicbrainz-tests tag for the schema change Verify the OpenJDK/Solr release checksums Update Java and Solr versions in Dockerfile.tests CheckSchemaMigration.sh: restore previous t/sql/initial.sql Fix installing pending.so MBS-13557: Set a Referrer-Policy on login/register pages (#3245) MBS-13403: Drop unused priority column from link_type (#3179) MBS-12359: Refactor _columns implementation in data model (#3192) MBS-13361: Require PostgreSQL 16 (#3234) MBS-13514: Support 6-digit label codes (#3208)
yvanzo
added a commit
that referenced
this pull request
May 13, 2024
* beta: Update translation files Update POT files using the production database Update Yarn version to the latest 4.2.2 Fix installing our xgettext-js fork using Yarn v4 MBS-11962: Update privileges for all database users on schema changes Add `@FULL_SCHEMA_LIST` to constants Split upgrade script for MBS-13514 Remove `CONCURRENTLY` from inside transaction blocks MBS-13421: Add support for genre collections (#3183) Fix a couple issues with the Solr test service Set a new musicbrainz-tests tag for the schema change Verify the OpenJDK/Solr release checksums Update Java and Solr versions in Dockerfile.tests CheckSchemaMigration.sh: restore previous t/sql/initial.sql Fix installing pending.so MBS-13557: Set a Referrer-Policy on login/register pages (#3245) MBS-13403: Drop unused priority column from link_type (#3179) MBS-12359: Refactor _columns implementation in data model (#3192) MBS-13361: Require PostgreSQL 16 (#3234) MBS-13514: Support 6-digit label codes (#3208)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-12359
Description
This changes the implementation of
_columnsto list each column on one row, and turns it into a lazy Moose attribute using abuilderin order to cache the result of thejoincall.Testing
Only automated testing at the moment.