Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more string dupes #3201

Merged
merged 2 commits into from Mar 11, 2024
Merged

Fix more string dupes #3201

merged 2 commits into from Mar 11, 2024

Conversation

reosarevok
Copy link
Member

No description provided.

@reosarevok
Avoid duplicated string with / without period
ef77370
@reosarevok
Avoid duplicated string with / without period and use ID
5e9bc01 
We already use uppercase ID elsewhere - since we need to break
one of the strings to standardize, we can fix that too.
@reosarevok reosarevok added the Refactoring Refactoring-only PRs (eslint fixes etc) label Mar 11, 2024
yvanzo
yvanzo approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🚢

@reosarevok reosarevok merged commit 8314754 into metabrainz:master Mar 11, 2024
2 of 3 checks passed
@reosarevok reosarevok deleted the more-string-dupes branch March 11, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvanzo yvanzo yvanzo approved these changes

Assignees
No one assigned
Labels
Refactoring Refactoring-only PRs (eslint fixes etc)
Projects
None yet
Milestone
No milestone
2 participants
@reosarevok @yvanzo