MBS-13558 (I): Migrate React components to Flow component syntax #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
force-pushed
the
flow-component-syntax
branch
3 times, most recently
from
ccd32fb
to
d91215b
Compare
reosarevok
force-pushed
the
flow-component-syntax
branch
from
d91215b
to
f25d67d
Compare
mwiencek
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
I skimmed the commits and didn't see any obvious problems. Also did not notice any problems on the subset of pages I checked locally. Since the type checking for component is supposed to be more strict than the previous function forms in some ways, I personally think it's fine to merge this given the passing tests.
Should we have a refactoring ticket for this?
reosarevok
changed the title
This is only used in one place, so there's no need to have a separate types file just for it.
This is only used in one place, so there's no need to have a separate types file just for it.
This is only used in one place, so there's no need to have it in a separate types file.
This is only used in one place, so there's no need to have it in a separate types file.
This is only used in one place, so there's no need to have it in a separate types file.
This is only used in one place, so there's no need to have it in a separate types file.
This is only used in one place, so there's no need to have it in a separate types file.
Map will have the index anyway, so we don't need to pass it in these cases.
In order to make use of the benefits of the syntax, converted components/TagEntiesList here too so I can use its props to avoid defining things twice.
Flow wasn't happy with us passing variables we don't use as part of props. I made some changes on how we do typing here that actually allowed me to drop the separate types file entirely.
No changes to text content, all changes are moving words around for max-len purposes
reosarevok
force-pushed
the
flow-component-syntax
branch
from
f25d67d
to
7830caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow now supports a specific React Component Syntax which reduces the amount of types we need to define manually, and is supposed to be better for type checking as well. I'm converting our React components to this syntax bit by bit with this PR.
This changes all stuff in
rootsubfolders except for the largest ones which probably need a PR for each to be less insane:/components,/edit,/layout,/reportand/static.Note: To be reviewed without whitespace changes (since this adds explicit
return()calls that require spacing things one more tab in many cases).