Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate React static components to Flow component syntax #3231

Merged
merged 8 commits into from
May 17, 2024
Merged

Migrate React static components to Flow component syntax #3231

merged 8 commits into from
May 17, 2024

Commits on May 17, 2024

  1. Drop unneeded instance typing in hydrate input 

    Instance is optional and defaults to mixed.
See https://flow.org/en/docs/react/types/#toc-react-abstractcomponent

This also causes issues when an input component's type
does not have a void instance.
    @reosarevok
    reosarevok committed May 17, 2024
    Configuration menu
    Copy the full SHA
    28071fe View commit details
    Browse the repository at this point in the history

  2. Drop dead code in AddEntityDialog 

    Modal doesn't actually use its onClick prop at all, so this is dead code.
It seems it's not needed either.
    @reosarevok
    reosarevok committed May 17, 2024
    Configuration menu
    Copy the full SHA
    85d9db4 View commit details
    Browse the repository at this point in the history

  3. Convert /static/scripts/common/components templates to use Flow compo… 

    …nent syntax

Except for class components which should be converted
but are less trivial to change.
    @reosarevok
    reosarevok committed May 17, 2024
    Configuration menu
    Copy the full SHA
    014e2fb View commit details
    Browse the repository at this point in the history

  4. Convert /static/scripts/edit/components templates to use Flow compone… 

    …nt syntax

Multiselect needs a lot of changes to fix the Flow issues hidden by FlowIgnore,
will look into it in a separate commit.
    @reosarevok
    reosarevok committed May 17, 2024
    Configuration menu
    Copy the full SHA
    ca8fce9 View commit details
    Browse the repository at this point in the history

  5. Remove seemingly useless double export 

    These are already the default exports
    @reosarevok
    reosarevok committed May 17, 2024
    Configuration menu
    Copy the full SHA
    f6e7f48 View commit details
    Browse the repository at this point in the history

  6. Convert some more /static/scripts/ templates to use Flow component sy… 

    …ntax
    @reosarevok
    reosarevok committed May 17, 2024
    Configuration menu
    Copy the full SHA
    ce81ed0 View commit details
    Browse the repository at this point in the history

  7. Convert /static/scripts/relationship-editor templates to use Flow com… 

    …ponent syntax
    @reosarevok
    reosarevok committed May 17, 2024
    Configuration menu
    Copy the full SHA
    3345980 View commit details
    Browse the repository at this point in the history

  8. Convert /static/scripts/release templates to use Flow component syntax

    @reosarevok
    reosarevok committed May 17, 2024
    Configuration menu
    Copy the full SHA
    8d66563 View commit details
    Browse the repository at this point in the history