New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate React /component components to Flow component syntax #3236
Draft
reosarevok
wants to merge
58
commits into
metabrainz:master
Choose a base branch
from
reosarevok:flow-component-syntax-components
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Migrate React /component components to Flow component syntax #3236
reosarevok
wants to merge
58
commits into
metabrainz:master
from
reosarevok:flow-component-syntax-components
+11,326
−14,018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
force-pushed
the
flow-component-syntax-components
branch
from
April 15, 2024 18:00
6047d04
to
8f44e84
Compare
This is only used in one place, so there's no need to have a separate types file just for it.
This is only used in one place, so there's no need to have a separate types file just for it.
This is only used in one place, so there's no need to have it in a separate types file.
This is only used in one place, so there's no need to have it in a separate types file.
This is only used in one place, so there's no need to have it in a separate types file.
This is only used in one place, so there's no need to have it in a separate types file.
This is only used in one place, so there's no need to have it in a separate types file.
Map will have the index anyway, so we don't need to pass it in these cases.
In order to make use of the benefits of the syntax, converted components/TagEntiesList here too so I can use its props to avoid defining things twice.
Flow wasn't happy with us passing variables we don't use as part of props. I made some changes on how we do typing here that actually allowed me to drop the separate types file entirely.
No changes to text content, all changes are moving words around for max-len purposes
For VoteCheckbox in Vote.js, Flow was unhappy with us passing a generic ...props to the input, since in theory the props can contain different name, type etc from what we're passing separately. This just changes it to pass value specifically, which seems to be the intention based on Flow typing.
reosarevok
force-pushed
the
flow-component-syntax-components
branch
from
April 16, 2024 09:08
8f44e84
to
76eee9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow now supports a specific React Component Syntax which reduces the amount of types we need to define manually, and is supposed to be better for type checking as well. I'm converting our React components to this syntax bit by bit with this PR.
This changes all stuff in the
components
subfolder.Note: To be reviewed without whitespace changes (since this adds explicit
return()
calls that require spacing things one more tab in many cases).On top of #3230