MBS-13560: Sync Entity::Artist with beta
#3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, LGTM. |
`Entity::Artist` is missing a couple Moose attributes that were added to the beta code. Entities that are cached on production but loaded on beta will be missing these, and cause beta to crash. The relevant changes have been synced from d981ba8.
|
I forgot we also need the part in |
yvanzo
added a commit
that referenced
this pull request
Apr 29, 2024
* production: MBS-13560: Sync `Entity::Artist` with beta (#3252) Amend e5776e7: Fix testing four-byte characters Amend e5776e7: Improve phrasing by reosarevok MBS-13562 (III): Check editing unlimited strings MBS-13562 (II): Set indexable string size to 2704 MBS-13562 (I): Set one-line string length to 1024
yvanzo
added a commit
that referenced
this pull request
Apr 29, 2024
* master: Update POT files using the production database MBS-13560: Sync `Entity::Artist` with beta (#3252) Amend e5776e7: Fix testing four-byte characters Amend e5776e7: Improve phrasing by reosarevok MBS-13562 (III): Check editing unlimited strings MBS-13562 (II): Set indexable string size to 2704 MBS-13562 (I): Set one-line string length to 1024 MBS-13533: Fix order of cover art in release group artwork (#3238)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MBS-13560
Entity::Artistis missing a couple Moose attributes that were added to the beta code. Entities that are cached on production but loaded on beta will be missing these, and cause beta to crash.Solution
The relevant changes have been synced from d981ba8.
Testing
Just the existing automated tests.