Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert form_row_text_list to React #3264

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Serial-ATA
Copy link

Problem

This is related to MBS-12755. This is just converting the form_row_text_list TT macro to a React component to make the conversion of the edit pages possible.

Solution

This is just a direct translation of the TT macro. I'm no web developer, so this may not be the best.

Testing

I converted area/edit_form.tt separately and tested with that.

demo

I didn't include that yet to keep this simple.

Further action

I plan to use this to convert the edit pages in follow up PRs.

Copy link

welcome bot commented May 16, 2024

Thanks for opening your first pull request for MusicBrainz Server, and welcome to our community! 🎉
If you haven’t yet, please check out our contributing guidelines.
Someone will be reviewing your PR soon; just hang in there!
In the meantime, if you’re wondering what to do next, you can have a look at our issue tracker.

@brainzbot
Copy link
Member

Can one of the admins verify this patch?

@yvanzo
Copy link
Contributor

yvanzo commented May 16, 2024

@brainzbot, add to whitelist

@yvanzo
Copy link
Contributor

yvanzo commented May 16, 2024

Thanks a lot for submitting this pull request!

Please note that there is some work in progress to start with converting Event edit form to React, as MBS-11063 is a sub-task of MBS-12755. Sorry if it wasn’t clear from the ticket, I just added a comment to avoid any further misinterpretation.

We will review the Event PR #2672 at first, and see if your present contribution can help with making it even better.

@Serial-ATA
Copy link
Author

Ah thanks, I hadn't seen MBS-11063. The list of tasks on MBS-12755 was collapsed for some reason so I only saw the first 5.

#2672 will help simplify my implementation of the area edit form later, since it adds the Bubble component. I think the only forms that use form_row_text_list are area, artist, label, recording, and work, so this will still be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants