Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add display placeholder for EAA edits in production #3271

Merged
merged 3 commits into from
May 23, 2024
Merged

Add display placeholder for EAA edits in production #3271

merged 3 commits into from
May 23, 2024

Commits on May 23, 2024

  1. Add BetaOnlyEdit placeholder for edit types in beta testing 

    This is a prerequisite step for IMG-84 / PR metabrainz#3150.

If you were to submit any of the new EAA edits on the beta server once it's
deployed there, and then try to load any of those edits in production (whether
directly or via an edit listing), then it would cause an ISE in production.

Pulling all of the display code for these new edit types would basically mean
having to merge a very large chunk of the event-art-archive branch, as they
depend heavily on changes to the `Data::` and `Entity::` layers.

This patch adds a placeholder component, `BetaOnlyEdit`, which can be used to
link these EAA edits to the beta server (saying that they can only be viewed
there temporarily).

In a subsequent commit I will add in the machinery to actually make use of this
component for the EAA edits specifically. It may also be useful for other new
edit types we introduce in the future.
    @mwiencek
    mwiencek committed May 23, 2024
    Configuration menu
    Copy the full SHA
    a8e12fd View commit details
    Browse the repository at this point in the history

  2. Add constants for EAA edit types 

    Adds constants defining all of the edit type IDs needed for IMG-84.
    @mwiencek
    mwiencek committed May 23, 2024
    Configuration menu
    Copy the full SHA
    842f009 View commit details
    Browse the repository at this point in the history

  3. Add EAA edit class stubs linking to BetaOnlyEdit 

    This is a prerequisite step for IMG-84 / PR metabrainz#3150.

It adds temporary (stub) edit classes that don't do anything except display the
type of edit. The core display of the edits is delegated to the `BetaOnlyEdit`
component added in a8e12fd.
    @mwiencek
    mwiencek committed May 23, 2024
    Configuration menu
    Copy the full SHA
    e5d0ff4 View commit details
    Browse the repository at this point in the history