Update RemoveSpamAccount admin script for MBS-9357 (part 1) #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
approved these changes
Jun 27, 2017
admin/RemoveSpamAccounts.pl
Outdated
| "dryrun|d" => \$dry_run, | ||
| "force|f" => \$force, | ||
| ) or return 2; | ||
| "caseinsensitive|i" => \$case_insensitive, |
There was a problem hiding this comment.
ignore-case|i for matching is?
admin/RemoveSpamAccounts.pl
Outdated
| foreach my $ed (@{$editors}) { | ||
| my $details = "'" . $ed->{name} . "'"; | ||
| if ($verbose && $column ne 'name') { | ||
| $details .= " [${column}='" . $ed->{$column} . "']"; |
There was a problem hiding this comment.
Since you're intentionally adding surrounding '', I assume you want that to be a valid SQL literal, so I might suggest $dbh->quote($ed->{$column}) instead. I suppose it doesn't matter if this is just for logging, but outputting unescaped quotes could potentially be irritating in either case. :P
yvanzo
force-pushed
the
mbs-9357-part-1-admin-script
branch
from
851bba1
to
3ce91a4
Compare
- Allow filtering on email, website, and bio (additionally to name) - Support POSIX regular expression (in place of prefix) - Use case-sensitive operator by default (instead of insensitive) - Preserve accounts with edits/votes/OAuth tokens by default - Add options for operator case-sensitivity and verbosity level - Show help message (documentation) in case of incorrect usage
yvanzo
force-pushed
the
mbs-9357-part-1-admin-script
branch
from
3ce91a4
to
0842e29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of MBS-9357: