MBS-9675, MBS-9676: Fix work attributes localization issues in the work creation dialog #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
approved these changes
May 30, 2018
root/forms/dialog.tt
Outdated
| SET gettext_domains = []; | ||
| END; | ||
| IF dialog_template == "work/edit_form.tt"; | ||
| SET gettext_domains.push('attributes'); |
There was a problem hiding this comment.
I think SET doesn't make sense there since it's not an assignment. (SET is optional for assignments, even.)
There was a problem hiding this comment.
oops, removed in 43f032e
in work creation dialog specifically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix both bugs MBS-9675 and MBS-9676 for good
Cause was translation domain
attributeswas not loaded from the work creation dialog (opened from the release relationship editor), whereas it is required for adding new works when no existing work is found.It reverts change from PR #673, and load gettext domain “attributes” for work creation dialog specifically.