Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-90: Fix tag lookups for artist #689

Merged
merged 2 commits into from Jul 3, 2018
Merged

Conversation

@samj1912
Copy link
Member

samj1912 commented Jul 1, 2018

Tag lookups for artist was using a search modifier to search for sortnames and aliases with a particular boost. This is not needed or supported anymore (since it uses a weird syntax) with Solr since these fields are searched by default with a particular set of boosts

Tag lookups for artist was using a search modifier to search for sortnames and aliases with a particular boost. This is not needed anymore with Solr since these fields are searched by default with a particular set of boosts
@samj1912 samj1912 force-pushed the samj1912:taglookup branch from 4823d8c to cbcc89d Jul 1, 2018
@samj1912 samj1912 changed the title Fix tag lookups for artist SOLR-90: Fix tag lookups for artist Jul 1, 2018
@samj1912 samj1912 requested review from mwiencek and yvanzo Jul 1, 2018
Copy link
Member

mwiencek left a comment

Looks like the alias_query subroutine is now unused and can be removed.

@samj1912

This comment has been minimized.

Copy link
Member Author

samj1912 commented Jul 2, 2018

@mwiencek updated.

@samj1912

This comment has been minimized.

Copy link
Member Author

samj1912 commented Jul 2, 2018

@brainzbot retest this please.

@goodenep

This comment has been minimized.

Copy link

goodenep commented Jul 2, 2018

Just tested and Artist only tag lookup still does not work.

@yvanzo
yvanzo approved these changes Jul 2, 2018
Copy link
Contributor

yvanzo left a comment

:shipit:

@goodenep : It was not deployed, it works in beta already.

@yvanzo

This comment has been minimized.

Copy link
Contributor

yvanzo commented Jul 3, 2018

@goodenep : It is now fixed for every MusicBrainz server, check artist only tag lookup.

@goodenep

This comment has been minimized.

Copy link

goodenep commented Jul 3, 2018

Thank you and everyone else for this "fast" fix. I apologize for being so pushy. I can verify it works.

@mwiencek mwiencek merged commit ee1beca into metabrainz:master Jul 3, 2018
1 check passed
1 check passed
Jenkins Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.