New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBS-10063: Create and edit work edits should display [No lyrics] for zxx #966

Merged

mwiencek merged 2 commits into metabrainz:master from reosarevok:MBS-10063

Apr 1, 2019

Member

reosarevok commented Mar 7, 2019

https://tickets.metabrainz.org/browse/MBS-10063


          MBS-10063: Edit work edit should display [No lyrics] for zxx

2997b2a

reosarevok requested review from mwiencek and yvanzo

March 7, 2019 07:12


          MBS-10063: Create work edit should display [No lyrics] for zxx

a35a5c7

reosarevok changed the title ~~MBS-10063: Edit work edit should display [No lyrics] for zxx~~ Create and edit work edits should display [No lyrics] for zxx

reosarevok changed the title ~~Create and edit work edits should display [No lyrics] for zxx~~ MBS-10063: Create and edit work edits should display [No lyrics] for zxx

yvanzo approved these changes

View reviewed changes

Contributor

yvanzo left a comment

Tested! 🔨

mwiencek approved these changes

View reviewed changes

Member

mwiencek left a comment

LGTM though we should probably generalize this in the future so we don't have to do this replacement in four different places. :)

mwiencek merged commit 74381e7 into metabrainz:master

reosarevok deleted the MBS-10063 branch

March 11, 2020 19:10

reosarevok mentioned this pull request

MBS-7835: Old Create work edits should display [No lyrics] for zxx #1421

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment