MBS-10087: Convert doc pages to React #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
commented
Mar 28, 2019
root/doc/DocPage.js
Outdated
| }: Props) => { | ||
| let doc = ''; | ||
| let lastDoc = ''; | ||
| const wikiPageUrl = `//${wikiServer}/${id}`; |
There was a problem hiding this comment.
I was going to use encodeURIComponent() here, but it messes up with the slashes, so hopefully we don't need to.
mwiencek
reviewed
May 8, 2019
reosarevok
force-pushed
the
MBS-10087
branch
2 times, most recently
from
d7cd0ee
to
517d40e
Compare
mwiencek
requested changes
May 28, 2019
mwiencek
requested changes
Jun 1, 2019
mwiencek
approved these changes
Jun 5, 2019
yvanzo
reviewed
Jul 24, 2019
| @@ -1,20 +0,0 @@ | |||
| <h1>[%- l('Page Not Found') -%]</h1> | |||
There was a problem hiding this comment.
root/doc/bare_error.tt should be deleted by the first commit instead
There was a problem hiding this comment.
Can't, because doc_error actually uses it ([% PROCESS 'doc/bare_error.tt' %])
There was a problem hiding this comment.
musicbrainz-server/root/doc/error.tt
Line 7 in d371cc3
This allows to consistently access headers, solving an issue where they were expected capitalized in some places and lowercased in others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.metabrainz.org/browse/MBS-10087
Talking with @mwiencek we decided to get rid of the bare_ pages, because they didn't seem to be requested ever and we can't find any info of why they were added.